From 4badf40afcbe489deda92812e72a99a0e54f11a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Fri, 17 Dec 2021 23:24:17 +0100 Subject: [PATCH] Add TODOs --- lib/livebook/evaluator.ex | 1 + test/livebook/intellisense_test.exs | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/livebook/evaluator.ex b/lib/livebook/evaluator.ex index 2cc0fc787..274e7e4f8 100644 --- a/lib/livebook/evaluator.ex +++ b/lib/livebook/evaluator.ex @@ -324,6 +324,7 @@ defmodule Livebook.Evaluator do defp eval(code, binding, env) do try do quoted = Code.string_to_quoted!(code) + # TODO: Use Code.eval_quoted_with_env/3 on Elixir v1.14 {result, binding, env} = :elixir.eval_quoted(quoted, binding, env) {:ok, result, binding, env} diff --git a/test/livebook/intellisense_test.exs b/test/livebook/intellisense_test.exs index b3145a419..9395e8517 100644 --- a/test/livebook/intellisense_test.exs +++ b/test/livebook/intellisense_test.exs @@ -9,6 +9,7 @@ defmodule Livebook.IntellisenseTest.Utils do quote do block = unquote(Macro.escape(block)) binding = [] + # TODO: Use Code.eval_quoted_with_env/3 on Elixir v1.14 env = :elixir.env_for_eval([]) {_, binding, env} = :elixir.eval_quoted(block, binding, env) {binding, env}