livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2024-09-20 10:05:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make smart cell editor rounded (#1105)

Browse source
This commit is contained in:
Jonatan Kłosko 2022-04-13 20:03:21 +02:00 committed by GitHub
parent 5606326203
commit 4f5d6b39a1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/livebook_web/live/session_live/cell_component.ex
View file

@ -174,7 +174,8 @@ defmodule LivebookWeb.SessionLive.CellComponent do
cell_id={@cell_view.id}
tag="secondary"
source_view={@cell_view.editor.source_view}
language={@cell_view.editor.language} />
language={@cell_view.editor.language}
rounded={@cell_view.editor.placement} />
<% end %>
</div>

7
lib/livebook_web/live/session_live/cell_editor_component.ex
View file

@ -13,6 +13,7 @@ defmodule LivebookWeb.SessionLive.CellEditorComponent do
|> assign(assigns)
|> assign_new(:intellisense, fn -> false end)
|> assign_new(:read_only, fn -> false end)
|> assign_new(:rounded, fn -> :both end)
socket =
if not connected?(socket) or socket.assigns.initialized do
@ -42,7 +43,7 @@ defmodule LivebookWeb.SessionLive.CellEditorComponent do
phx-hook="CellEditor"
data-cell-id={@cell_id}
data-tag={@tag}>
<div class="py-3 rounded-lg bg-editor" data-el-editor-container>
<div class={"py-3 #{rounded_class(@rounded)} bg-editor"} data-el-editor-container>
<div class="px-8" data-el-skeleton>
<.content_skeleton bg_class="bg-gray-500" empty={empty?(@source_view)} />
</div>
@ -53,4 +54,8 @@ defmodule LivebookWeb.SessionLive.CellEditorComponent do
defp empty?(%{source: ""} = _source_view), do: true
defp empty?(_source_view), do: false
defp rounded_class(:both), do: "rounded-lg"
defp rounded_class(:top), do: "rounded-t-lg"
defp rounded_class(:bottom), do: "rounded-b-lg"
end