Partially revert "Removes deployment group deletion (#2479)" (#2480)

* Revert "Removes deployment group deletion (#2479)

proto/lib/livebook_proto.ex

@@ -11,6 +11,7 @@ defmodule LivebookProto do
     SecretDeleted,
     SecretUpdated,
     DeploymentGroupCreated,
+    DeploymentGroupDeleted,
     DeploymentGroupUpdated,
     UserConnected
   }
@@ -31,6 +32,7 @@ defmodule LivebookProto do
           | SecretDeleted.t()
           | SecretUpdated.t()
           | DeploymentGroupCreated.t()
+          | DeploymentGroupDeleted.t()
           | DeploymentGroupUpdated.t()
           | UserConnected.t()
 

proto/lib/livebook_proto/deployment_group_deleted.pb.ex

@@ -0,0 +1,5 @@
+defmodule LivebookProto.DeploymentGroupDeleted do
+  use Protobuf, syntax: :proto3, protoc_gen_elixir_version: "0.12.0"
+
+  field :id, 1, type: :string
+end

proto/lib/livebook_proto/event.pb.ex

@@ -48,17 +48,22 @@ defmodule LivebookProto.Event do
     json_name: "deploymentGroupUpdated",
     oneof: 0
 
-  field :agent_connected, 10,
+  field :deployment_group_deleted, 10,
+    type: LivebookProto.DeploymentGroupDeleted,
+    json_name: "deploymentGroupDeleted",
+    oneof: 0
+
+  field :agent_connected, 11,
     type: LivebookProto.AgentConnected,
     json_name: "agentConnected",
     oneof: 0
 
-  field :agent_key_created, 11,
+  field :agent_key_created, 12,
     type: LivebookProto.AgentKeyCreated,
     json_name: "agentKeyCreated",
     oneof: 0
 
-  field :agent_key_deleted, 12,
+  field :agent_key_deleted, 13,
     type: LivebookProto.AgentKeyDeleted,
     json_name: "agentKeyDeleted",
     oneof: 0

test/livebook_teams/web/hub/deployment_group_live_test.exs

@@ -112,7 +112,7 @@ defmodule LivebookWeb.Integration.Hub.DeploymentGroupLiveTest do
 
     assert_receive {:deployment_group_updated, ^updated_deployment_group}
     assert_patch(view, "/hub/#{hub.id}/deployment-groups/edit/#{deployment_group.id}")
-    assert render(view) =~ "Deployment group FOO updated successfully"
+    assert render(view) =~ "Deployment group #{new_name} updated successfully"
     assert updated_deployment_group in Livebook.Teams.get_deployment_groups(hub)
   end
 

test/livebook_teams/web/hub/edit_live_test.exs

@@ -407,7 +407,7 @@ defmodule LivebookWeb.Integration.Hub.EditLiveTest do
 
       assert_receive {:deployment_group_updated, ^updated_deployment_group}
       assert_patch(view, "/hub/#{hub.id}/deployment-groups/edit/#{deployment_group.id}")
-      assert render(view) =~ "Deployment group FOO updated successfully"
+      assert render(view) =~ "Deployment group #{new_name} updated successfully"
       assert updated_deployment_group in Livebook.Teams.get_deployment_groups(hub)
     end
 

test/support/hub_helpers.ex

@@ -188,6 +188,16 @@ defmodule Livebook.HubHelpers do
     send(pid, {:event, :deployment_group_created, deployment_group_created})
   end
 
+  def remove_offline_hub_deployment_group(deployment_group) do
+    hub = offline_hub()
+    {:ok, pid} = hub_pid(hub)
+
+    deployment_group_deleted =
+      %LivebookProto.DeploymentGroupDeleted{id: deployment_group.id}
+
+    send(pid, {:event, :deployment_group_deleted, deployment_group_deleted})
+  end
+
   def put_offline_hub_file_system(file_system) do
     hub = offline_hub()
     {:ok, pid} = hub_pid(hub)