livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-10-06 19:46:00 +08:00
Code Issues Projects Releases Packages Wiki Activity

Reflect app status as errored when runtime crashes (#2681)

Browse source
This commit is contained in:
Jonatan Kłosko 2024-06-25 21:03:02 +02:00 • committed by GitHub
parent 85520a60b2
commit 597abe161c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 35 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/livebook/session/data.ex
View file

@ -1981,6 +1981,7 @@ defmodule Livebook.Session.Data do
data_actions
|> clear_all_evaluation()
|> clear_smart_cells()
|> app_update_execution_status()
end
end

35
test/livebook/session/data_test.exs
View file

@ -4257,7 +4257,24 @@ defmodule Livebook.Session.DataTest do
Data.apply_operation(data, operation)
end
test "changes status to :error when evaluation is aborted and returns recover action" do
test "changes status to :error when evaluation is aborted" do
data =
data_after_operations!(Data.new(mode: :app), [
{:insert_section, @cid, 0, "s1"},
{:insert_cell, @cid, "s1", 0, :code, "c1", %{}},
{:insert_cell, @cid, "s1", 1, :code, "c2", %{}},
{:set_runtime, @cid, connected_noop_runtime()},
evaluate_cells_operations(["setup"]),
{:queue_cells_evaluation, @cid, ["c1"]}
])
operation = {:reflect_main_evaluation_failure, @cid}
assert {:ok, %{app_data: %{status: %{execution: :error}}}, [:app_report_status]} =
Data.apply_operation(data, operation)
end
test "returns recover action when fully executed and then aborted" do
data =
data_after_operations!(Data.new(mode: :app), [
{:insert_section, @cid, 0, "s1"},
@ -4273,6 +4290,22 @@ defmodule Livebook.Session.DataTest do
[:app_report_status, :app_recover]} = Data.apply_operation(data, operation)
end
test "changes status to :error when a non-connected runtime is set" do
data =
data_after_operations!(Data.new(mode: :app), [
{:insert_section, @cid, 0, "s1"},
{:insert_cell, @cid, "s1", 0, :code, "c1", %{}},
{:insert_cell, @cid, "s1", 1, :code, "c2", %{}},
{:set_runtime, @cid, connected_noop_runtime()},
{:queue_cells_evaluation, @cid, ["setup"]}
])
operation = {:set_runtime, @cid, Livebook.Runtime.NoopRuntime.new()}
assert {:ok, %{app_data: %{status: %{execution: :error}}}, [:app_report_status]} =
Data.apply_operation(data, operation)
end
test "changes status to :error when evaluation finishes with error" do
data =
data_after_operations!(Data.new(mode: :app), [