From 5c106e81fa5273ba3bdbadbad4c8bfc3d5dd7a13 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Valim?= <jose.valim@dashbit.co>
Date: Thu, 9 Mar 2023 17:41:40 +0100
Subject: [PATCH] Small changes (#1764)

---
 lib/livebook_web/live/hub/edit/personal_component.ex     | 5 ++++-
 lib/livebook_web/live/hub/secret_form_component.ex       | 4 ++--
 lib/livebook_web/live/session_live/app_info_component.ex | 4 ++--
 lib/livebook_web/live/session_live/secrets_component.ex  | 4 ++--
 test/livebook_web/live/hub/edit_live_test.exs            | 2 +-
 5 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/lib/livebook_web/live/hub/edit/personal_component.ex b/lib/livebook_web/live/hub/edit/personal_component.ex
index 2bfee9d89..2c01624d3 100644
--- a/lib/livebook_web/live/hub/edit/personal_component.ex
+++ b/lib/livebook_web/live/hub/edit/personal_component.ex
@@ -102,6 +102,9 @@ defmodule LivebookWeb.Hub.Edit.PersonalComponent do
     ~H"""
     <div id={@id} class="flex flex-col space-y-4">
       <div class="flex flex-col space-y-4">
+        <.no_entries :if={@secrets == []}>
+          No secrets in this Hub yet.
+        </.no_entries>
         <div
           :for={secret <- @secrets}
           class="flex items-center justify-between border border-gray-200 rounded-lg p-4"
@@ -111,7 +114,7 @@ defmodule LivebookWeb.Hub.Edit.PersonalComponent do
       </div>
       <div class="flex">
         <.link patch={@new_secret_path} class="button-base button-blue" id="add-secret">
-          Add new secret
+          Add secret
         </.link>
       </div>
     </div>
diff --git a/lib/livebook_web/live/hub/secret_form_component.ex b/lib/livebook_web/live/hub/secret_form_component.ex
index 04205e279..3e48b7bb5 100644
--- a/lib/livebook_web/live/hub/secret_form_component.ex
+++ b/lib/livebook_web/live/hub/secret_form_component.ex
@@ -43,7 +43,7 @@ defmodule LivebookWeb.Hub.SecretFormComponent do
               autofocus={@secret_name == nil}
               spellcheck="false"
               autocomplete="off"
-              phx-debounce="blur"
+              phx-debounce
               class="uppercase"
             />
             <.text_field
@@ -52,7 +52,7 @@ defmodule LivebookWeb.Hub.SecretFormComponent do
               autofocus={@secret_name != nil}
               spellcheck="false"
               autocomplete="off"
-              phx-debounce="blur"
+              phx-debounce
             />
             <.hidden_field field={f[:hub_id]} value={@hub.id} />
             <div class="flex space-x-2">
diff --git a/lib/livebook_web/live/session_live/app_info_component.ex b/lib/livebook_web/live/session_live/app_info_component.ex
index 7838510fc..0d48ee5eb 100644
--- a/lib/livebook_web/live/session_live/app_info_component.ex
+++ b/lib/livebook_web/live/session_live/app_info_component.ex
@@ -70,7 +70,7 @@ defmodule LivebookWeb.SessionLive.AppInfoComponent do
               autocomplete="off"
             >
               <div class="flex flex-col space-y-4">
-                <.text_field field={f[:slug]} label="Slug" spellcheck="false" phx-debounce="blur" />
+                <.text_field field={f[:slug]} label="Slug" spellcheck="false" phx-debounce />
                 <div class="flex flex-col space-y-1">
                   <.checkbox_field
                     field={f[:access_type]}
@@ -79,7 +79,7 @@ defmodule LivebookWeb.SessionLive.AppInfoComponent do
                     unchecked_value="public"
                   />
                   <%= if Ecto.Changeset.get_field(@changeset, :access_type) == :protected do %>
-                    <.password_field field={f[:password]} spellcheck="false" phx-debounce="blur" />
+                    <.password_field field={f[:password]} spellcheck="false" phx-debounce />
                   <% end %>
                 </div>
                 <.checkbox_field field={f[:show_source]} label="Show source" />
diff --git a/lib/livebook_web/live/session_live/secrets_component.ex b/lib/livebook_web/live/session_live/secrets_component.ex
index 50e26a1c6..4b0e0e681 100644
--- a/lib/livebook_web/live/session_live/secrets_component.ex
+++ b/lib/livebook_web/live/session_live/secrets_component.ex
@@ -100,7 +100,7 @@ defmodule LivebookWeb.SessionLive.SecretsComponent do
               autofocus={@prefill_secret_name == nil}
               spellcheck="false"
               autocomplete="off"
-              phx-debounce="blur"
+              phx-debounce
               class="uppercase"
             />
             <.text_field
@@ -109,7 +109,7 @@ defmodule LivebookWeb.SessionLive.SecretsComponent do
               autofocus={@prefill_secret_name != nil}
               spellcheck="false"
               autocomplete="off"
-              phx-debounce="blur"
+              phx-debounce
             />
             <.radio_field
               field={f[:hub_id]}
diff --git a/test/livebook_web/live/hub/edit_live_test.exs b/test/livebook_web/live/hub/edit_live_test.exs
index 6ca890b46..f1ac0b144 100644
--- a/test/livebook_web/live/hub/edit_live_test.exs
+++ b/test/livebook_web/live/hub/edit_live_test.exs
@@ -283,7 +283,7 @@ defmodule LivebookWeb.Hub.EditLiveTest do
       |> render_click(%{})
 
       assert_patch(view, ~p"/hub/#{hub.id}/secrets/new")
-      assert render(view) =~ "Add new secret"
+      assert render(view) =~ "Add secret"
 
       view
       |> element("#secrets-form")