livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-09-10 23:14:35 +08:00
Code Issues Projects Releases Packages Wiki Activity

Fix race condition in ZTA tests (#2064)

Browse source 
* ZTA tests - non-asynchronous

* Unique names
This commit is contained in:
Cristine Guadelupe 2023-07-12 18:01:03 +02:00 • committed by GitHub
parent 8c3f0bf046
commit 61c19a30dd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
test/livebook/zta/cloudflare_test.exs
View file

@ -5,6 +5,7 @@ defmodule Livebook.ZTA.CloudflareTest do
alias Livebook.ZTA.Cloudflare
@fields [:id, :name, :email]
@name Context.Test.Claudflare
setup do
bypass = Bypass.open()
@ -24,7 +25,7 @@ defmodule Livebook.ZTA.CloudflareTest do
"eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwiZW1haWwiOiJ0dWthQHBlcmFsdGEuY29tIiwiaWF0IjoxNTE2MjM5MDIyLCJpc3MiOiJsaXZlYm9vayIsImF1ZCI6ImxpdmVib29rd2ViIn0.ZP5LIrkfMHq2p8g3SMgC7RBt7899GeHkP9rzYKM3RvjDCBeYoxpeioLW2sXMT74QyJPxB4JUujRU3shSPIWNAxkjJVaBGwVTqsO_PR34DSx82q45qSkUnkSVXLl-2KgN4BoUUK7dmocP6yzhNQ3XGf6669n5UG69eMZdh9PApZ7GuyRUQ80ubpvakWaIpd9PIaORkptqDWVbyOIk3Z79AMUub0MSG1FpzYByAQoLswob24l2xVo95-aQrdatqLk1sJ43AZ6HLoMxkZkWobYYRMH5w65MkQckJ9NzI3Rk-VOUlg9ePo8OPRnvcGY-OozHXrjdzn2-j03xuP6x1J3Y7Q"
options = [
name: LivebookWeb.ZTA,
name: @name,
custom_identity: %{
iss: "livebook",
key: "livebookweb",
@ -59,7 +60,7 @@ defmodule Livebook.ZTA.CloudflareTest do
end)
start_supervised!({Cloudflare, context.options})
{_conn, user} = Cloudflare.authenticate(LivebookWeb.ZTA, context.conn, fields: @fields)
{_conn, user} = Cloudflare.authenticate(@name, context.conn, fields: @fields)
assert %{id: "1234567890", email: "tuka@peralta.com", name: "Tuka Peralta"} = user
end
@ -73,7 +74,7 @@ defmodule Livebook.ZTA.CloudflareTest do
start_supervised!({Cloudflare, context.options})
assert {_conn, nil} = Cloudflare.authenticate(LivebookWeb.ZTA, context.conn, fields: @fields)
assert {_conn, nil} = Cloudflare.authenticate(@name, context.conn, fields: @fields)
end
test "returns nil when the iss is invalid", %{options: options, conn: conn} do
@ -81,21 +82,21 @@ defmodule Livebook.ZTA.CloudflareTest do
options = Keyword.put(options, :custom_identity, invalid_identity)
start_supervised!({Cloudflare, options})
assert {_conn, nil} = Cloudflare.authenticate(LivebookWeb.ZTA, conn, fields: @fields)
assert {_conn, nil} = Cloudflare.authenticate(@name, conn, fields: @fields)
end
test "returns nil when the token is invalid", %{options: options} do
conn = conn(:get, "/") |> put_req_header("cf-access-jwt-assertion", "invalid_token")
start_supervised!({Cloudflare, options})
assert {_conn, nil} = Cloudflare.authenticate(LivebookWeb.ZTA, conn, fields: @fields)
assert {_conn, nil} = Cloudflare.authenticate(@name, conn, fields: @fields)
end
test "returns nil when the assertion is invalid", %{options: options, token: token} do
conn = conn(:get, "/") |> put_req_header("invalid_assertion", token)
start_supervised!({Cloudflare, options})
assert {_conn, nil} = Cloudflare.authenticate(LivebookWeb.ZTA, conn, fields: @fields)
assert {_conn, nil} = Cloudflare.authenticate(@name, conn, fields: @fields)
end
test "returns nil when the key is invalid", %{bypass: bypass, options: options, conn: conn} do
@ -107,6 +108,6 @@ defmodule Livebook.ZTA.CloudflareTest do
start_supervised!({Cloudflare, options})
assert {_conn, nil} = Cloudflare.authenticate(LivebookWeb.ZTA, conn, fields: @fields)
assert {_conn, nil} = Cloudflare.authenticate(@name, conn, fields: @fields)
end
end

15
test/livebook/zta/google_iap_test.exs
View file

@ -5,6 +5,7 @@ defmodule Livebook.ZTA.GoogleIAPTest do
alias Livebook.ZTA.GoogleIAP
@fields [:id, :name, :email]
@name Context.Test.GoogleIAP
setup do
bypass = Bypass.open()
@ -23,7 +24,7 @@ defmodule Livebook.ZTA.GoogleIAPTest do
"eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwiZW1haWwiOiJ0dWthQHBlcmFsdGEuY29tIiwiaWF0IjoxNTE2MjM5MDIyLCJpc3MiOiJsaXZlYm9vayIsImF1ZCI6ImxpdmVib29rd2ViIn0.ZP5LIrkfMHq2p8g3SMgC7RBt7899GeHkP9rzYKM3RvjDCBeYoxpeioLW2sXMT74QyJPxB4JUujRU3shSPIWNAxkjJVaBGwVTqsO_PR34DSx82q45qSkUnkSVXLl-2KgN4BoUUK7dmocP6yzhNQ3XGf6669n5UG69eMZdh9PApZ7GuyRUQ80ubpvakWaIpd9PIaORkptqDWVbyOIk3Z79AMUub0MSG1FpzYByAQoLswob24l2xVo95-aQrdatqLk1sJ43AZ6HLoMxkZkWobYYRMH5w65MkQckJ9NzI3Rk-VOUlg9ePo8OPRnvcGY-OozHXrjdzn2-j03xuP6x1J3Y7Q"
options = [
name: LivebookWeb.ZTA,
name: @name,
custom_identity: %{
iss: "livebook",
key: "livebookweb",
@ -44,7 +45,7 @@ defmodule Livebook.ZTA.GoogleIAPTest do
test "returns the user when it's valid", %{options: options, conn: conn} do
start_supervised!({GoogleIAP, options})
{_conn, user} = GoogleIAP.authenticate(LivebookWeb.ZTA, conn, fields: @fields)
{_conn, user} = GoogleIAP.authenticate(@name, conn, fields: @fields)
assert %{id: "1234567890", email: "tuka@peralta.com"} = user
end
@ -53,7 +54,7 @@ defmodule Livebook.ZTA.GoogleIAPTest do
options = Keyword.put(options, :custom_identity, invalid_identity)
start_supervised!({GoogleIAP, options})
assert {_conn, nil} = GoogleIAP.authenticate(LivebookWeb.ZTA, conn, fields: @fields)
assert {_conn, nil} = GoogleIAP.authenticate(@name, conn, fields: @fields)
end
test "returns nil when the aud is invalid", %{options: options, conn: conn} do
@ -61,21 +62,21 @@ defmodule Livebook.ZTA.GoogleIAPTest do
options = Keyword.put(options, :custom_identity, invalid_identity)
start_supervised!({GoogleIAP, options})
assert {_conn, nil} = GoogleIAP.authenticate(LivebookWeb.ZTA, conn, fields: @fields)
assert {_conn, nil} = GoogleIAP.authenticate(@name, conn, fields: @fields)
end
test "returns nil when the token is invalid", %{options: options} do
conn = conn(:get, "/") |> put_req_header("x-goog-iap-jwt-assertion", "invalid_token")
start_supervised!({GoogleIAP, options})
assert {_conn, nil} = GoogleIAP.authenticate(LivebookWeb.ZTA, conn, fields: @fields)
assert {_conn, nil} = GoogleIAP.authenticate(@name, conn, fields: @fields)
end
test "returns nil when the assertion is invalid", %{options: options, token: token} do
conn = conn(:get, "/") |> put_req_header("invalid_assertion", token)
start_supervised!({GoogleIAP, options})
assert {_conn, nil} = GoogleIAP.authenticate(LivebookWeb.ZTA, conn, fields: @fields)
assert {_conn, nil} = GoogleIAP.authenticate(@name, conn, fields: @fields)
end
test "returns nil when the key is invalid", %{bypass: bypass, options: options, conn: conn} do
@ -87,6 +88,6 @@ defmodule Livebook.ZTA.GoogleIAPTest do
start_supervised!({GoogleIAP, options})
assert {_conn, nil} = GoogleIAP.authenticate(LivebookWeb.ZTA, conn, fields: @fields)
assert {_conn, nil} = GoogleIAP.authenticate(@name, conn, fields: @fields)
end
end