livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-02-24 23:09:23 +08:00
Code Issues Projects Releases Packages Wiki Activity

Limit the number of files listed in the file selector (#2491)

Browse source
This commit is contained in:
Jonatan Kłosko 2024-02-19 17:08:41 +01:00 committed by GitHub
parent 02b3acc4ae
commit 63376cb3ee
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 29 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
lib/livebook_web/live/file_select_component.ex
View file

@ -228,10 +228,10 @@ defmodule LivebookWeb.FileSelectComponent do
</div>
<div
:if={any_highlighted?(@file_infos)}
:if={@highlighted_file_infos != []}
class="grid grid-cols-2 sm:grid-cols-3 lg:grid-cols-4 gap-2 border-b border-dashed border-grey-200 mb-2 pb-2"
>
<%= for file_info <- @file_infos, file_info.highlighted != "" do %>
<%= for file_info <- Enum.take(@highlighted_file_infos, visible_files_limit()) do %>
<.file
id={"#{@id}-file-#{file_info.id}"}
file_info={file_info}
@ -240,10 +240,11 @@ defmodule LivebookWeb.FileSelectComponent do
renamed_name={@renamed_name}
/>
<% end %>
<.more_files_indicator length={length(@highlighted_file_infos)} />
</div>
<div class="grid grid-cols-2 sm:grid-cols-3 lg:grid-cols-4 gap-2">
<%= for file_info <- @file_infos, file_info.highlighted == "" do %>
<%= for file_info <- Enum.take(@unhighlighted_file_infos, visible_files_limit()) do %>
<.file
id={"#{@id}-file-#{file_info.id}"}
file_info={file_info}
@ -252,6 +253,7 @@ defmodule LivebookWeb.FileSelectComponent do
renamed_name={@renamed_name}
/>
<% end %>
<.more_files_indicator length={length(@unhighlighted_file_infos)} />
</div>
</form>
</div>
@ -289,10 +291,6 @@ defmodule LivebookWeb.FileSelectComponent do
"""
end
defp any_highlighted?(file_infos) do
Enum.any?(file_infos, &(&1.highlighted != ""))
end
defp file_system_menu_button(assigns) do
~H"""
<.menu id={@id} disabled={@file_system_select_disabled} position={:bottom_left}>
@ -448,6 +446,20 @@ defmodule LivebookWeb.FileSelectComponent do
"""
end
defp more_files_indicator(assigns) do
~H"""
<div
:if={@length > visible_files_limit()}
class="col-span-full text-sm text-medium text-gray-500 flex flex-col items-center gap-1"
>
<.remix_icon icon="more-line" class="text-lg" />
<%= @length - visible_files_limit() %> more files (search to see)
</div>
"""
end
defp visible_files_limit(), do: 200
defp js_show_new_item_section(js \\ %JS{}, id) do
js
|> JS.show(to: "##{id}")
@ -620,7 +632,16 @@ defmodule LivebookWeb.FileSelectComponent do
{current_file_infos, socket}
end
assign(socket, :file_infos, annotate_matching(file_infos, prefix))
file_infos = annotate_matching(file_infos, prefix)
{unhighlighted_file_infos, highlighted_file_infos} =
Enum.split_with(file_infos, &(&1.highlighted == ""))
assign(socket,
file_infos: file_infos,
unhighlighted_file_infos: unhighlighted_file_infos,
highlighted_file_infos: highlighted_file_infos
)
end
defp annotate_matching(file_infos, prefix) do