livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2024-09-20 18:15:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make session view menu visible on mobile

Browse source
This commit is contained in:
Jonatan Kłosko 2023-07-19 21:19:31 +02:00
parent 122cb67aa6
commit 6ba2a7433d
2 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
lib/livebook_web/components/core_components.ex
View file

@ -254,6 +254,10 @@ defmodule LivebookWeb.CoreComponents do
default: :bottom_right,
values: [:top_left, :top_right, :bottom_left, :bottom_right]
attr :sm_position, :atom,
default: nil,
values: [nil, :top_left, :top_right, :bottom_left, :bottom_right]
attr :md_position, :atom,
default: nil,
values: [nil, :top_left, :top_right, :bottom_left, :bottom_right]
@ -289,6 +293,7 @@ defmodule LivebookWeb.CoreComponents do
"absolute z-[100] rounded-lg bg-white flex flex-col py-2 shadow-[0_15px_99px_-0px_rgba(12,24,41,0.15)] hidden",
menu_position_class(@position),
@md_position && menu_md_position_class(@md_position),
@sm_position && menu_sm_position_class(@sm_position),
@distant && menu_distant_class(@position)
]}
role="menu"
@ -331,6 +336,23 @@ defmodule LivebookWeb.CoreComponents do
"md:bottom-0 md:right-0 md:top-auto md:left-auto md:transform md:translate-y-full md:-mb-1 md:mt-0"
end
defp menu_sm_position_class(:top_left) do
"sm:top-0 sm:left-0 sm:bottom-auto sm:right-auto sm:transform sm:-translate-y-full sm:-mt-1 sm:mb-0"
end
defp menu_sm_position_class(:top_right) do
"sm:top-0 sm:right-0 sm:bottom-auto sm:left-auto sm:transform sm:-translate-y-full sm:-mt-1 sm:mb-0"
end
defp menu_sm_position_class(:bottom_left) do
"sm:bottom-0 sm:left-0 sm:top-auto sm:right-auto sm:transform sm:translate-y-full sm:-mb-1 sm:mt-0"
end
defp menu_sm_position_class(:bottom_right) do
"sm:bottom-0 sm:right-0 sm:top-auto sm:left-auto sm:transform sm:translate-y-full sm:-mb-1 sm:mt-0"
end
defp menu_distant_class(position) when position in [:top_left, :top_right], do: "-mt-2"
defp menu_distant_class(position) when position in [:bottom_left, :bottom_right], do: "-mb-2"

2
lib/livebook_web/live/session_live/indicators_component.ex
View file

@ -56,7 +56,7 @@ defmodule LivebookWeb.SessionLive.IndicatorsComponent do
defp view_indicator(assigns) do
~H"""
<div class="tooltip left" data-tooltip="Choose views to activate" data-el-views>
<.menu id="views-menu" position={:top_right}>
<.menu id="views-menu" position={:bottom_right} sm_position={:top_right}>
<:toggle>
<button
class="icon-button icon-outlined-button border-gray-200 hover:bg-gray-100 focus:bg-gray-100"