From 6bd7bbd1fc40ad7fdc152d0d9b6ce607fd38c7e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Tue, 23 Apr 2024 19:47:44 +0200 Subject: [PATCH] Fix race condition on select secret --- lib/livebook_web/live/session_live/secrets_component.ex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/livebook_web/live/session_live/secrets_component.ex b/lib/livebook_web/live/session_live/secrets_component.ex index c1c83651e..0e1fa3944 100644 --- a/lib/livebook_web/live/session_live/secrets_component.ex +++ b/lib/livebook_web/live/session_live/secrets_component.ex @@ -247,7 +247,7 @@ defmodule LivebookWeb.SessionLive.SecretsComponent do if attrs["hub"] do secret = Enum.find(socket.assigns.hub_secrets, &(&1.name == secret_name)) - unless Session.Data.secret_toggled?(secret, socket.assigns.secrets) do + if secret && !Session.Data.secret_toggled?(secret, socket.assigns.secrets) do Session.set_secret(socket.assigns.session.pid, secret) end end