mirror of
https://github.com/livebook-dev/livebook.git
synced 2025-11-12 15:11:47 +08:00
Remove URL field from shared deployment group settings
This commit is contained in:
parent
da1ee6a308
commit
7507704de6
4 changed files with 17 additions and 17 deletions
|
|
@ -442,8 +442,8 @@ defmodule Livebook.Hubs.Dockerfile do
|
||||||
defp config_warnings(config) do
|
defp config_warnings(config) do
|
||||||
[
|
[
|
||||||
if config.clustering == nil do
|
if config.clustering == nil do
|
||||||
"The deployment is not configured for clustering. Make sure to run only one instance" <>
|
"Clustering has not been configured for this deployment. " <>
|
||||||
" of Livebook, or configure clustering."
|
"You must either configure it below or make sure to run only one instance of this server."
|
||||||
end
|
end
|
||||||
]
|
]
|
||||||
end
|
end
|
||||||
|
|
|
||||||
|
|
@ -93,20 +93,6 @@ defmodule LivebookWeb.AppComponents do
|
||||||
~H"""
|
~H"""
|
||||||
<div>
|
<div>
|
||||||
<div class="flex flex-col gap-4">
|
<div class="flex flex-col gap-4">
|
||||||
<.text_field
|
|
||||||
label="URL"
|
|
||||||
help={
|
|
||||||
~S'''
|
|
||||||
If you provide the URL you
|
|
||||||
will host your instances at,
|
|
||||||
Livebook will use it to
|
|
||||||
generate direct links
|
|
||||||
throughout its interface
|
|
||||||
'''
|
|
||||||
}
|
|
||||||
field={@form[:url]}
|
|
||||||
/>
|
|
||||||
|
|
||||||
<div>
|
<div>
|
||||||
<.select_field
|
<.select_field
|
||||||
label="Clustering"
|
label="Clustering"
|
||||||
|
|
|
||||||
|
|
@ -92,6 +92,20 @@ defmodule LivebookWeb.Hub.Teams.DeploymentGroupFormComponent do
|
||||||
phx-debounce
|
phx-debounce
|
||||||
/>
|
/>
|
||||||
|
|
||||||
|
<.text_field
|
||||||
|
label="URL"
|
||||||
|
help={
|
||||||
|
~S'''
|
||||||
|
If you provide the URL you
|
||||||
|
will host your instances at,
|
||||||
|
Livebook will use it to
|
||||||
|
generate direct links
|
||||||
|
throughout its interface
|
||||||
|
'''
|
||||||
|
}
|
||||||
|
field={@form[:url]}
|
||||||
|
/>
|
||||||
|
|
||||||
<.hidden_field field={@form[:hub_id]} value={@hub.id} />
|
<.hidden_field field={@form[:hub_id]} value={@hub.id} />
|
||||||
|
|
||||||
<LivebookWeb.AppComponents.deployment_group_form_content hub={@hub} form={@form} />
|
<LivebookWeb.AppComponents.deployment_group_form_content hub={@hub} form={@form} />
|
||||||
|
|
|
||||||
|
|
@ -385,7 +385,7 @@ defmodule Livebook.Hubs.DockerfileTest do
|
||||||
app_settings = Livebook.Notebook.AppSettings.new()
|
app_settings = Livebook.Notebook.AppSettings.new()
|
||||||
|
|
||||||
assert [warning] = Dockerfile.airgapped_warnings(config, hub, [], [], app_settings, [], %{})
|
assert [warning] = Dockerfile.airgapped_warnings(config, hub, [], [], app_settings, [], %{})
|
||||||
assert warning =~ "The deployment is not configured for clustering"
|
assert warning =~ "Clustering has not been configured for this deployment"
|
||||||
|
|
||||||
config = %{config | clustering: :auto}
|
config = %{config | clustering: :auto}
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Add table
Reference in a new issue