From 7cac0557b90b93312c9db785d0f364672241951a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonatan=20K=C5=82osko?= Date: Tue, 21 Feb 2023 13:17:54 +0100 Subject: [PATCH] Keep setup cell open on error (#1718) --- assets/css/js_interop.css | 5 ++++- lib/livebook_web/live/session_live/cell_component.ex | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/assets/css/js_interop.css b/assets/css/js_interop.css index ef19fc934..079d91ea3 100644 --- a/assets/css/js_interop.css +++ b/assets/css/js_interop.css @@ -131,7 +131,7 @@ solely client-side operations. [data-el-session] [data-el-cell][data-type="setup"]:not( [data-eval-validity="fresh"]:not([data-js-empty]) - ):not([data-js-changed]):not([data-js-focused]) + ):not([data-eval-errored]):not([data-js-changed]):not([data-js-focused]) [data-el-editor-box] { @apply h-0 overflow-hidden; } @@ -144,6 +144,9 @@ solely client-side operations. [data-js-empty] ) [data-el-info-box], +[data-el-session] + [data-el-cell][data-type="setup"][data-eval-errored] + [data-el-info-box], [data-el-session] [data-el-cell][data-type="setup"][data-js-changed] [data-el-info-box] { diff --git a/lib/livebook_web/live/session_live/cell_component.ex b/lib/livebook_web/live/session_live/cell_component.ex index c76bf6907..c26559b15 100644 --- a/lib/livebook_web/live/session_live/cell_component.ex +++ b/lib/livebook_web/live/session_live/cell_component.ex @@ -15,6 +15,7 @@ defmodule LivebookWeb.SessionLive.CellComponent do data-session-path={Routes.session_path(@socket, :page, @session_id)} data-evaluation-digest={get_in(@cell_view, [:eval, :evaluation_digest])} data-eval-validity={get_in(@cell_view, [:eval, :validity])} + data-eval-errored={get_in(@cell_view, [:eval, :errored])} data-js-empty={empty?(@cell_view.source_view)} data-smart-cell-js-view-ref={smart_cell_js_view_ref(@cell_view)} data-allowed-uri-schemes={Enum.join(@allowed_uri_schemes, ",")}