From 7fc8f24d2c9d874688e97b46a986cd80f18bde32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonatan=20K=C5=82osko?= Date: Thu, 27 Jan 2022 15:47:04 +0100 Subject: [PATCH] Fix image uploads in Markdown cells (#945) * Fix call to consume_uploaded_entries to match changes in LV * Escape reserved characters when inserting image in a Markdown cell --- .../live/session_live/cell_upload_component.ex | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/livebook_web/live/session_live/cell_upload_component.ex b/lib/livebook_web/live/session_live/cell_upload_component.ex index f41d42ed2..320b32a8f 100644 --- a/lib/livebook_web/live/session_live/cell_upload_component.ex +++ b/lib/livebook_web/live/session_live/cell_upload_component.ex @@ -82,13 +82,16 @@ defmodule LivebookWeb.SessionLive.CellUploadComponent do filename = name <> ext destination_file = FileSystem.File.resolve(images_dir, filename) - with :ok <- FileSystem.File.copy(upload_file, destination_file) do - {:ok, filename} - end + result = + with :ok <- FileSystem.File.copy(upload_file, destination_file) do + {:ok, filename} + end + + {:ok, result} end) |> case do [{:ok, filename}] -> - src_path = "images/#{filename}" + src_path = "images/#{URI.encode(filename, &URI.char_unreserved?/1)}" {:noreply, socket