livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-09-10 23:14:35 +08:00
Code Issues Projects Releases Packages Wiki Activity

Check for flag instead of non-empty dir (#2176)

Browse source
This commit is contained in:
José Valim 2023-08-22 15:51:05 +02:00 • committed by GitHub
parent 3ab0ab495d
commit 7ff6103475
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/livebook/session.ex
View file

@ -290,18 +290,20 @@ defmodule Livebook.Session do
@spec fetch_assets(pid(), String.t()) :: :ok | {:error, String.t()}
def fetch_assets(pid, hash) do
local_assets_path = local_assets_path(hash)
flag_path = Path.join(local_assets_path, ".lb-done")
if non_empty_dir?(local_assets_path) do
if File.exists?(flag_path) do
:ok
else
with {:ok, runtime, archive_path} <-
GenServer.call(pid, {:get_runtime_and_archive_path, hash}, @timeout) do
fun = fn ->
# Make sure the file hasn't been fetched by this point
unless non_empty_dir?(local_assets_path) do
unless File.exists?(flag_path) do
{:ok, archive_binary} = Runtime.read_file(runtime, archive_path)
extract_archive!(archive_binary, local_assets_path)
gzip_files(local_assets_path)
File.touch(flag_path)
end
end
@ -315,10 +317,6 @@ defmodule Livebook.Session do
end
end
defp non_empty_dir?(path) do
match?({:ok, [_ | _]}, File.ls(path))
end
@doc """
Sends notebook attributes update to the server.
"""