livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-12-09 13:16:08 +08:00
Code Issues Projects Releases Packages Wiki Activity

Improving Table Core Component (#2463)

Browse source
This commit is contained in:
Paulo Valim 2024-01-30 18:05:09 +01:00 • committed by GitHub
parent ddeefa3ab1
commit 80a8085073
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
lib/livebook_web/components/core_components.ex
View file

@ -774,18 +774,12 @@ defmodule LivebookWeb.CoreComponents do
~H"""
<div class="overflow-y-auto px-4 sm:overflow-visible sm:px-0">
<table class="min-w-full divide-y divide-gray-300">
<thead>
<thead class="text-sm text-left font-semibold leading-6 text-gray-900">
<tr>
<th
:for={col <- @col}
class="py-3.5 pl-4 pr-3 text-left text-sm font-semibold text-gray-900 sm:pl-6"
>
<th :for={col <- @col} class="py-3.5 pl-4 pr-3 sm:pl-6">
<%= col[:label] %>
</th>
<th
:if={@action != []}
class="py-3.5 pl-3 pr-5 text-right text-sm font-semibold text-gray-900 sm:pr-7"
>
<th :if={@action != []} class="py-3.5 pl-3 pr-5 text-right sm:pr-7">
<span>Actions</span>
</th>
</tr>
@ -793,23 +787,23 @@ defmodule LivebookWeb.CoreComponents do
<tbody
id={@id}
phx-update={match?(%Phoenix.LiveView.LiveStream{}, @rows) && "stream"}
class="divide-y divide-gray-200 bg-white"
class="relative divide-y divide-gray-200 bg-white text-sm font-medium leading-6 text-gray-900"
>
<tr :for={row <- @rows} id={@row_id && @row_id.(row)} class="group hover:bg-gray-50">
<td
:for={{col, i} <- Enum.with_index(@col)}
:for={col <- @col}
phx-click={@row_click && @row_click.(row)}
class={["relative p-0", @row_click && "hover:cursor-pointer"]}
>
<div class="block p-4 sm:px-6">
<span class="absolute -inset-y-px right-0 -left-4 group-hover:bg-gray-100 sm:rounded-l-xl" />
<span class={["relative", i == 0 && "text-sm font-medium text-gray-900"]}>
<span class="relative">
<%= render_slot(col, @row_item.(row)) %>
</span>
</div>
</td>
<td :if={@action != []} class="relative p-0">
<div class="relative whitespace-nowrap py-4 pl-3 pr-4 text-sm font-medium sm:pr-6 flex justify-end items-center">
<div class="relative whitespace-nowrap py-4 pl-3 pr-4 sm:pr-6 flex justify-end items-center">
<span class="absolute -inset-y-px -right-4 left-0 group-hover:bg-gray-100 sm:rounded-r-xl" />
<span :for={action <- @action} class="relative ml-4">
<%= render_slot(action, @row_item.(row)) %>