livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-11-08 13:11:56 +08:00
Code Issues Projects Releases Packages Wiki Activity

Pass only the Livebook PID to child LiveViews (#2081)

Browse source
This commit is contained in:
José Valim 2023-07-17 10:56:30 +02:00 • committed by GitHub
parent 319ce562cb
commit 82909f7f35
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 25 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/livebook_web/live/session_live.ex
View file

@ -554,7 +554,7 @@ defmodule LivebookWeb.SessionLive do
<%= live_render(@socket, LivebookWeb.SessionLive.PackageSearchLive,
id: "package-search",
session: %{
"session" => @session,
"session_pid" => @session.pid,
"runtime" => @data_view.runtime,
"return_to" => @self_path
}

8
lib/livebook_web/live/session_live/attached_live.ex
View file

@ -4,7 +4,13 @@ defmodule LivebookWeb.SessionLive.AttachedLive do
alias Livebook.{Session, Runtime}
@impl true
def mount(_params, %{"session" => session, "current_runtime" => current_runtime}, socket) do
def mount(
_params,
%{"session_pid" => session_pid, "current_runtime" => current_runtime},
socket
) do
session = Session.get_by_pid(session_pid)
unless Livebook.Config.runtime_enabled?(Livebook.Runtime.Attached) do
raise "runtime module not allowed"
end

8
lib/livebook_web/live/session_live/elixir_standalone_live.ex
View file

@ -4,7 +4,13 @@ defmodule LivebookWeb.SessionLive.ElixirStandaloneLive do
alias Livebook.{Session, Runtime}
@impl true
def mount(_params, %{"session" => session, "current_runtime" => current_runtime}, socket) do
def mount(
_params,
%{"session_pid" => session_pid, "current_runtime" => current_runtime},
socket
) do
session = Session.get_by_pid(session_pid)
unless Livebook.Config.runtime_enabled?(Livebook.Runtime.ElixirStandalone) do
raise "runtime module not allowed"
end

8
lib/livebook_web/live/session_live/embedded_live.ex
View file

@ -4,7 +4,13 @@ defmodule LivebookWeb.SessionLive.EmbeddedLive do
alias Livebook.{Session, Runtime}
@impl true
def mount(_params, %{"session" => session, "current_runtime" => current_runtime}, socket) do
def mount(
_params,
%{"session_pid" => session_pid, "current_runtime" => current_runtime},
socket
) do
session = Session.get_by_pid(session_pid)
unless Livebook.Config.runtime_enabled?(Livebook.Runtime.Embedded) do
raise "runtime module not allowed"
end

4
lib/livebook_web/live/session_live/package_search_live.ex
View file

@ -4,12 +4,12 @@ defmodule LivebookWeb.SessionLive.PackageSearchLive do
@impl true
def mount(
_params,
%{"session" => session, "runtime" => runtime, "return_to" => return_to},
%{"session_pid" => session_pid, "runtime" => runtime, "return_to" => return_to},
socket
) do
socket =
assign(socket,
session: session,
session: Livebook.Session.get_by_pid(session_pid),
runtime: runtime,
return_to: return_to,
search: "",

2
lib/livebook_web/live/session_live/runtime_component.ex
View file

@ -61,7 +61,7 @@ defmodule LivebookWeb.SessionLive.RuntimeComponent do
<div>
<%= live_render(@socket, live_view_for_type(@type),
id: "runtime-config-#{@type}",
session: %{"session" => @session, "current_runtime" => @runtime}
session: %{"session_pid" => @session.pid, "current_runtime" => @runtime}
) %>
</div>
</div>