livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-03-01 09:24:05 +08:00
Code Issues Projects Releases Packages Wiki Activity

Fix auth with Livebook teams when user not belongs to org (#2865)

Browse source
This commit is contained in:
Hugo Baraúna 2024-11-20 23:25:22 -03:00 committed by GitHub
parent 4eaf442a5a
commit 96a995bf26
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/livebook/zta/livebook_teams.ex
View file

@ -53,8 +53,8 @@ defmodule Livebook.ZTA.LivebookTeams do
defp handle_request(conn, _team, %{"teams_identity" => _, "failed_reason" => reason}) do
{conn
|> redirect(to: conn.request_path)
|> put_session(:teams_failed_reason, reason)
|> redirect(to: conn.request_path)
|> halt(), nil}
end

26
test/livebook_teams/zta/livebook_teams_test.exs
View file

@ -75,5 +75,31 @@ defmodule Livebook.ZTA.LivebookTeamsTest do
assert conn.halted
assert html_response(conn, 200) =~ "window.location.href = "
end
test "shows an error when the user does not belong to the org", %{conn: conn, test: test} do
# Step 1: Emulate a request coming from Teams saying the user does belong to the org
conn = init_test_session(conn, %{})
params_from_teams = %{
"teams_identity" => "",
"failed_reason" => "you do not belong to this org"
}
conn = %Plug.Conn{conn | params: params_from_teams}
{conn, nil} = LivebookTeams.authenticate(test, conn, [])
session = Plug.Conn.get_session(conn)
assert conn.status == 302
# Step 2: follow the redirect keeping the session set in previous request
conn = build_conn(:get, redirected_to(conn))
conn = init_test_session(conn, session)
{conn, nil} = LivebookTeams.authenticate(test, conn, [])
assert html_response(conn, 200) =~
"Failed to authenticate with Livebook Teams: you do not belong to this org"
end
end
end