Make the error status clickable on failed deployments (#1854)

This commit is contained in:
José Valim 2023-04-12 22:16:43 +02:00 committed by GitHub
parent f681d2a244
commit 971b243f10
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 5 deletions

View file

@ -39,10 +39,10 @@ defmodule LivebookWeb.AppHelpers do
defp app_status_indicator(assigns) do
~H"""
<div class="flex items-center space-x-2">
<div :if={@text}><%= @text %></div>
<span class="flex items-center space-x-2">
<span :if={@text}><%= @text %></span>
<.status_indicator variant={@variant} />
</div>
</span>
"""
end
end

View file

@ -78,7 +78,14 @@ defmodule LivebookWeb.AppsLive do
<div class="flex flex-col md:flex-row space-y-4 md:space-y-0 md:space-x-8 w-full max-w-2xl">
<div class="flex-1">
<.labeled_text label="Status">
<a
class="inline-block"
aria-label="debug app"
href={@session.app_info.status == :error && ~p"/sessions/#{@session.id}"}
target="_blank"
>
<.app_status status={@session.app_info.status} />
</a>
</.labeled_text>
</div>
<div class="flex-1">

View file

@ -119,7 +119,14 @@ defmodule LivebookWeb.SessionLive.AppInfoComponent do
<div :for={app <- @apps} class="border border-gray-200 rounded-lg">
<div class="p-4 flex flex-col space-y-3">
<.labeled_text label="Status">
<a
class="inline-block"
aria-label="debug app"
href={app.status == :error && ~p"/sessions/#{app.session_id}"}
target="_blank"
>
<.app_status status={app.status} />
</a>
</.labeled_text>
<.labeled_text label="URL" one_line>
<%= if app.registered do %>