From 97f64b4af440c562100ceed4b78849173c56f88f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Wed, 8 Nov 2023 12:26:15 +0100 Subject: [PATCH] Add a connection error for offline hubs (#2326) --- lib/livebook/application.ex | 2 +- lib/livebook/hubs/team.ex | 13 ++++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/livebook/application.ex b/lib/livebook/application.ex index f69f80aeb..1f98aafb3 100644 --- a/lib/livebook/application.ex +++ b/lib/livebook/application.ex @@ -312,7 +312,7 @@ defmodule Livebook.Application do Livebook.Hubs.save_hub(%Livebook.Hubs.Team{ id: "team-#{name}", hub_name: name, - hub_emoji: "💡", + hub_emoji: "⭐️", user_id: 0, org_id: 0, org_key_id: 0, diff --git a/lib/livebook/hubs/team.ex b/lib/livebook/hubs/team.ex index d531e2198..dd915ff6a 100644 --- a/lib/livebook/hubs/team.ex +++ b/lib/livebook/hubs/team.ex @@ -38,7 +38,7 @@ defmodule Livebook.Hubs.Team do field :org_key_id, :integer field :teams_key, :string field :org_public_key, :string - field :session_token, :string + field :session_token, :string, redact: true field :hub_name, :string field :hub_emoji, :string @@ -137,8 +137,15 @@ defimpl Livebook.Hubs.Provider, for: Livebook.Hubs.Team do def delete_secret(team, secret), do: Teams.delete_secret(team, secret) def connection_error(team) do - if reason = TeamClient.get_connection_error(team.id) do - "Cannot connect to Hub: #{reason}.\nWill attempt to reconnect automatically..." + cond do + team.offline -> + "You are running an offline Hub for deployment. You cannot modify its settings." + + reason = TeamClient.get_connection_error(team.id) -> + "Cannot connect to Hub: #{reason}.\nWill attempt to reconnect automatically..." + + true -> + nil end end