From 9aac5ce86da17753736438d366149a9efe183015 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Valim?= <jose.valim@dashbit.co>
Date: Tue, 21 Nov 2023 20:06:23 +0800
Subject: [PATCH] Annotate download nodes to avoid socket disconnection, closes
 #2367

---
 .../live/session_live/export_elixir_component.ex            | 1 +
 .../live/session_live/export_live_markdown_component.ex     | 1 +
 lib/livebook_web/live/session_live/files_list_component.ex  | 6 +++++-
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/lib/livebook_web/live/session_live/export_elixir_component.ex b/lib/livebook_web/live/session_live/export_elixir_component.ex
index 3a5cf0350..a51868a38 100644
--- a/lib/livebook_web/live/session_live/export_elixir_component.ex
+++ b/lib/livebook_web/live/session_live/export_elixir_component.ex
@@ -37,6 +37,7 @@ defmodule LivebookWeb.SessionLive.ExportElixirComponent do
                 class="icon-button"
                 aria-label="download source"
                 href={~p"/sessions/#{@session.id}/export/download/exs"}
+                download
               >
                 <.remix_icon icon="download-2-line" class="text-lg" />
               </a>
diff --git a/lib/livebook_web/live/session_live/export_live_markdown_component.ex b/lib/livebook_web/live/session_live/export_live_markdown_component.ex
index b1b80a24a..1aa1d20f4 100644
--- a/lib/livebook_web/live/session_live/export_live_markdown_component.ex
+++ b/lib/livebook_web/live/session_live/export_live_markdown_component.ex
@@ -53,6 +53,7 @@ defmodule LivebookWeb.SessionLive.ExportLiveMarkdownComponent do
                 href={
                   ~p"/sessions/#{@session.id}/download/export/livemd?include_outputs=#{@include_outputs}"
                 }
+                download
               >
                 <.remix_icon icon="download-2-line" class="text-lg" />
               </a>
diff --git a/lib/livebook_web/live/session_live/files_list_component.ex b/lib/livebook_web/live/session_live/files_list_component.ex
index ca24c835a..ef898be33 100644
--- a/lib/livebook_web/live/session_live/files_list_component.ex
+++ b/lib/livebook_web/live/session_live/files_list_component.ex
@@ -143,7 +143,11 @@ defmodule LivebookWeb.SessionLive.FilesListComponent do
               </button>
             </.menu_item>
             <.menu_item>
-              <a role="menuitem" href={~p"/sessions/#{@session.id}/download/files/#{file_entry.name}"}>
+              <a
+                role="menuitem"
+                href={~p"/sessions/#{@session.id}/download/files/#{file_entry.name}"}
+                download
+              >
                 <.remix_icon icon="download-2-line" />
                 <span>Download</span>
               </a>