livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-02-24 14:58:35 +08:00
Code Issues Projects Releases Packages Wiki Activity

Fix logs not getting captured in RuntimeServer tests

Browse source
This commit is contained in:
Jonatan Kłosko 2023-12-15 14:35:09 +07:00
parent 0711040d67
commit 9ce18a3df8
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
test/livebook/runtime/erl_dist/runtime_server_test.exs
View file

@ -86,6 +86,10 @@ defmodule Livebook.Runtime.ErlDist.RuntimeServerTest do
assert_receive {:runtime_evaluation_output, :e1, terminal_text(log_message, true)} assert_receive {:runtime_evaluation_output, :e1, terminal_text(log_message, true)}
assert log_message =~ "[error] hey" assert log_message =~ "[error] hey"
# Stop the server explicitly to make sure all logger messages are
# sent by the time the test ends and stops capturing logs
RuntimeServer.stop(pid)
end end
test "supports cross-container evaluation context references", %{pid: pid} do test "supports cross-container evaluation context references", %{pid: pid} do
@ -219,6 +223,10 @@ defmodule Livebook.Runtime.ErlDist.RuntimeServerTest do
assert_receive {:runtime_container_down, :c1, message} assert_receive {:runtime_container_down, :c1, message}
assert message =~ "(RuntimeError) error" assert message =~ "(RuntimeError) error"
# Stop the server explicitly to make sure all logger messages are
# sent by the time the test ends and stops capturing logs
RuntimeServer.stop(pid)
end end
describe "smart cells" do describe "smart cells" do
@ -283,6 +291,10 @@ defmodule Livebook.Runtime.ErlDist.RuntimeServerTest do
test "notifies runtime owner when a smart cell fails to start", %{pid: pid} do test "notifies runtime owner when a smart cell fails to start", %{pid: pid} do
RuntimeServer.start_smart_cell(pid, "dumb", "ref", %{"crash" => true}, []) RuntimeServer.start_smart_cell(pid, "dumb", "ref", %{"crash" => true}, [])
assert_receive {:runtime_smart_cell_down, "ref"} assert_receive {:runtime_smart_cell_down, "ref"}
# Stop the server explicitly to make sure all logger messages are
# sent by the time the test ends and stops capturing logs
RuntimeServer.stop(pid)
end end
@tag opts: @opts @tag opts: @opts