livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2024-11-10 17:15:09 +08:00
Code Issues Projects Releases Packages Wiki Activity

Enable copy button for error output (#2435)

Browse source
This commit is contained in:
lkarthee 2024-01-22 13:26:39 +05:30 committed by GitHub
parent 07a43e3e74
commit a15a69175b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 33 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
lib/livebook_web/live/output.ex
View file

@ -257,9 +257,9 @@ defmodule LivebookWeb.Output do
defp render_output(
%{type: :error, context: {:missing_secret, secret_name}} = output,
%{session_id: session_id}
%{session_id: session_id, id: id}
) do
assigns = %{message: output.message, secret_name: secret_name, session_id: session_id}
assigns = %{message: output.message, secret_name: secret_name, session_id: session_id, id: id}
~H"""
<div class="-m-4 space-x-4 py-4">
@ -278,16 +278,21 @@ defmodule LivebookWeb.Output do
Add secret
</.link>
</div>
<%= render_formatted_error_message(@message) %>
<%= render_formatted_error_message(@id, @message) %>
</div>
"""
end
defp render_output(
%{type: :error, context: {:file_entry_forbidden, file_entry_name}} = output,
%{session_id: session_id}
%{session_id: session_id, id: id}
) do
assigns = %{message: output.message, file_entry_name: file_entry_name, session_id: session_id}
assigns = %{
message: output.message,
file_entry_name: file_entry_name,
session_id: session_id,
id: id
}
~H"""
<div class="-m-4 space-x-4 py-4">
@ -306,7 +311,7 @@ defmodule LivebookWeb.Output do
Review access
</button>
</div>
<%= render_formatted_error_message(@message) %>
<%= render_formatted_error_message(@id, @message) %>
</div>
"""
end
@ -346,8 +351,8 @@ defmodule LivebookWeb.Output do
"""
end
defp render_output(%{type: :error, message: message}, %{}) do
render_formatted_error_message(message)
defp render_output(%{type: :error, message: message}, %{id: id}) do
render_formatted_error_message(id, message)
end
defp render_output(output, %{}) do
@ -373,16 +378,28 @@ defmodule LivebookWeb.Output do
"""
end
defp render_formatted_error_message(formatted) do
assigns = %{message: formatted}
defp render_formatted_error_message(id, message) do
assigns = %{id: id, message: message}
~H"""
<div
class="whitespace-pre-wrap break-words font-editor text-gray-500"
role="complementary"
aria-label="error"
phx-no-format
><%= ansi_string_to_html(@message) %></div>
<div id={@id} class="relative group/error">
<div
id={"#{@id}-message"}
class="whitespace-pre-wrap break-words font-editor text-gray-500"
role="complementary"
aria-label="error"
phx-no-format
><%= ansi_string_to_html(@message) %></div>
<div class="absolute right-2 top-0 z-10 invisible group-hover/error:visible">
<button
class="icon-button bg-gray-100"
data-el-clipcopy
phx-click={JS.dispatch("lb:clipcopy", to: "##{@id}-message")}
>
<.remix_icon icon="clipboard-line" class="text-lg" />
</button>
</div>
</div>
"""
end
end