Metadata typo (#2195)

lib/livebook/hubs.ex

@@ -27,10 +27,10 @@ defmodule Livebook.Hubs do
   end
 
   @doc """
-  Gets a list of metadatas from storage.
+  Gets a list of metadata from storage.
   """
-  @spec get_metadatas() :: list(Metadata.t())
+  @spec get_metadata() :: list(Metadata.t())
-  def get_metadatas do
+  def get_metadata do
     for hub <- get_hubs() do
       Provider.to_metadata(hub)
     end

lib/livebook/hubs/personal.ex

@@ -53,7 +53,7 @@ defmodule Livebook.Hubs.Personal do
   @doc """
   Updates a Hub.
 
-  With success, notifies interested processes about hub metadatas data change.
+  With success, notifies interested processes about hub metadata data change.
   Otherwise, it will return an error tuple with changeset.
   """
   @spec update_hub(t(), map()) :: {:ok, t()} | {:error, Ecto.Changeset.t()}

lib/livebook/live_markdown/export.ex

@@ -107,14 +107,14 @@ defmodule Livebook.LiveMarkdown.Export do
 
     app_settings_metadata = app_settings_metadata(notebook.app_settings)
 
-    file_entry_metadatas =
+    file_entry_metadata =
       notebook.file_entries
       |> Enum.sort_by(& &1.name)
       |> Enum.map(&file_entry_metadata/1)
 
     put_unless_default(
       metadata,
-      %{app_settings: app_settings_metadata, file_entries: file_entry_metadatas},
+      %{app_settings: app_settings_metadata, file_entries: file_entry_metadata},
       %{app_settings: %{}, file_entries: []}
     )
   end

lib/livebook/live_markdown/import.ex

@@ -410,10 +410,10 @@ defmodule Livebook.LiveMarkdown.Import do
 
         {Map.put(attrs, :app_settings, app_settings), messages}
 
-      {"file_entries", file_entry_metadatas}, {attrs, messages}
+      {"file_entries", file_entry_metadata}, {attrs, messages}
-      when is_list(file_entry_metadatas) ->
+      when is_list(file_entry_metadata) ->
         file_system_by_id =
-          if Enum.any?(file_entry_metadatas, &(&1["type"] == "file")) do
+          if Enum.any?(file_entry_metadata, &(&1["type"] == "file")) do
             for file_system <- Livebook.Settings.file_systems(),
                 do: {file_system.id, file_system},
                 into: %{}
@@ -422,7 +422,7 @@ defmodule Livebook.LiveMarkdown.Import do
           end
 
         {file_entries, file_entry_messages} =
-          for file_entry_metadata <- file_entry_metadatas, reduce: {[], []} do
+          for file_entry_metadata <- file_entry_metadata, reduce: {[], []} do
             {file_entries, warnings} ->
               case file_entry_metadata_to_attrs(file_entry_metadata, file_system_by_id) do
                 {:ok, file_entry} -> {[file_entry | file_entries], warnings}

lib/livebook/teams.ex

@@ -156,7 +156,7 @@ defmodule Livebook.Teams do
   @doc """
   Creates a Hub.
 
-  It notifies interested processes about hub metadatas data change.
+  It notifies interested processes about hub metadata data change.
   """
   @spec create_hub!(map()) :: Team.t()
   def create_hub!(attrs) do
@@ -169,7 +169,7 @@ defmodule Livebook.Teams do
   @doc """
   Updates a Hub.
 
-  With success, notifies interested processes about hub metadatas data change.
+  With success, notifies interested processes about hub metadata data change.
   Otherwise, it will return an error tuple with changeset.
   """
   @spec update_hub(Team.t(), map()) :: {:ok, Team.t()} | {:error, Ecto.Changeset.t()}

lib/livebook_web/live/hooks/sidebar_hook.ex

@@ -13,7 +13,7 @@ defmodule LivebookWeb.SidebarHook do
 
     socket =
       socket
-      |> assign(saved_hubs: Livebook.Hubs.get_metadatas())
+      |> assign(saved_hubs: Livebook.Hubs.get_metadata())
       |> attach_hook(:hubs, :handle_info, &handle_info/2)
       |> attach_hook(:shutdown, :handle_info, &handle_info/2)
       |> attach_hook(:shutdown, :handle_event, &handle_event/3)
@@ -28,17 +28,17 @@ defmodule LivebookWeb.SidebarHook do
   @connection_events ~w(hub_connected hub_changed)a
 
   defp handle_info(event, socket) when elem(event, 0) in @connection_events do
-    {:cont, assign(socket, saved_hubs: Livebook.Hubs.get_metadatas())}
+    {:cont, assign(socket, saved_hubs: Livebook.Hubs.get_metadata())}
   end
 
   defp handle_info({:hub_connection_failed, _hub_id, _reason}, socket) do
-    {:cont, assign(socket, saved_hubs: Livebook.Hubs.get_metadatas())}
+    {:cont, assign(socket, saved_hubs: Livebook.Hubs.get_metadata())}
   end
 
   defp handle_info({:hub_server_error, _hub_id, error}, socket) do
     {:cont,
      socket
-     |> assign(saved_hubs: Livebook.Hubs.get_metadatas())
+     |> assign(saved_hubs: Livebook.Hubs.get_metadata())
      |> put_flash(:error, error)}
   end
 

test/livebook_teams/hubs_test.exs

@@ -11,14 +11,14 @@ defmodule Livebook.HubsTest do
     refute team in Hubs.get_hubs()
   end
 
-  test "get_metadatas/0 returns a list of persisted hubs normalized", %{user: user, node: node} do
+  test "get_metadata/0 returns a list of persisted hubs normalized", %{user: user, node: node} do
     team = create_team_hub(user, node)
     metadata = Hubs.Provider.to_metadata(team)
 
-    assert metadata in Hubs.get_metadatas()
+    assert metadata in Hubs.get_metadata()
 
     Hubs.delete_hub(team.id)
-    refute metadata in Hubs.get_metadatas()
+    refute metadata in Hubs.get_metadata()
   end
 
   test "fetch_hub!/1 returns one persisted team", %{user: user, node: node} do