livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-10-10 13:38:09 +08:00
Code Issues Projects Releases Packages Wiki Activity

Do not check Elixir version in the Fly runtime (#2710)

Browse source
This commit is contained in:
Jonatan Kłosko 2024-07-16 14:29:37 +02:00 • committed by GitHub
parent cb674cc8bd
commit a85b3b02f5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
lib/livebook/runtime/fly.ex
View file

@ -296,19 +296,14 @@ defmodule Livebook.Runtime.Fly do
defp fetch_runtime_info(child_node) do
# Note: it is Livebook that starts the runtime node, so we know
# that the node runs Livebook release of the exact same version
#
# Also, the remote node already has all the runtime modules in
# the code path, compiled for its Elixir version, so we don't
# need to check for matching Elixir version.
%{
pid: pid,
elixir_version: elixir_version
} = :erpc.call(child_node, :persistent_term, :get, [:livebook_runtime_info])
%{pid: pid} = :erpc.call(child_node, :persistent_term, :get, [:livebook_runtime_info])
if elixir_version != System.version() do
{:error,
"the local Elixir version (#{inspect(System.version())}) does not" <>
" match the one used by the runtime (#{elixir_version})"}
else
{:ok, pid}
end
{:ok, pid}
end
defp initialize_node(child_node) do

3
rel/server/overlays/bin/start_runtime.exs
View file

@ -13,8 +13,7 @@ node = :"#{node_base}@#{machine_id}.vm.#{app}.internal"
# We persist the information before the node is reachable
:persistent_term.put(:livebook_runtime_info, %{
pid: self(),
elixir_version: System.version()
pid: self()
})
Application.put_env(:kernel, :inet_dist_listen_min, dist_port)