From aa95d81729269f6f7d895f1dca720c4661eaa2be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jonatan=20K=C5=82osko?= <jonatanklosko@gmail.com>
Date: Fri, 16 Jul 2021 23:39:51 +0200
Subject: [PATCH] Fix completion crash on module attribute call (#451)

---
 lib/livebook/completion.ex        | 4 ++++
 test/livebook/completion_test.exs | 5 +++++
 2 files changed, 9 insertions(+)

diff --git a/lib/livebook/completion.ex b/lib/livebook/completion.ex
index 7e4f35783..79d2f5500 100644
--- a/lib/livebook/completion.ex
+++ b/lib/livebook/completion.ex
@@ -106,6 +106,10 @@ defmodule Livebook.Completion do
     {:ok, List.to_atom(var)}
   end
 
+  defp expand_dot_path({:module_attribute, _attribute}, _ctx) do
+    :error
+  end
+
   defp expand_dot_path({:dot, parent, call}, ctx) do
     case expand_dot_path(parent, ctx) do
       {:ok, %{} = map} -> Map.fetch(map, List.to_atom(call))
diff --git a/test/livebook/completion_test.exs b/test/livebook/completion_test.exs
index 032a46ecb..4255c588d 100644
--- a/test/livebook/completion_test.exs
+++ b/test/livebook/completion_test.exs
@@ -925,4 +925,9 @@ defmodule Livebook.CompletionTest do
              }
            ] = Completion.get_completion_items("@modu", binding, env)
   end
+
+  test "handles calls on module attribute" do
+    {binding, env} = eval(do: nil)
+    assert [] = Completion.get_completion_items("@attr.value", binding, env)
+  end
 end