livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-10-11 05:56:26 +08:00
Code Issues Projects Releases Packages Wiki Activity

Fix inserting code cell via shortcut

Browse source
This commit is contained in:
Jonatan Kłosko 2023-07-03 22:05:45 +02:00
parent 550869c356
commit ab3f3d6b0b
2 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
lib/livebook_web/live/session_live.ex
View file

@ -1884,7 +1884,7 @@ defmodule LivebookWeb.SessionLive do
end
defp insert_cell_below(socket, params) do
{type, attrs} = cell_type_and_attrs_from_params(params)
{type, attrs} = cell_type_and_attrs_from_params(params, socket)
with {:ok, section, index} <-
section_with_next_index(
@ -1898,13 +1898,22 @@ defmodule LivebookWeb.SessionLive do
socket
end
defp cell_type_and_attrs_from_params(%{"type" => "markdown"}), do: {:markdown, %{}}
defp cell_type_and_attrs_from_params(%{"type" => "markdown"}, _socket), do: {:markdown, %{}}
defp cell_type_and_attrs_from_params(%{"type" => "code", "language" => language})
when language in ["elixir", "erlang"],
do: {:code, %{language: String.to_atom(language)}}
defp cell_type_and_attrs_from_params(%{"type" => "code"} = params, socket) do
language =
case params["language"] do
language when language in ["elixir", "erlang"] ->
String.to_atom(language)
defp cell_type_and_attrs_from_params(%{"type" => "diagram"}) do
_ ->
socket.private.data.notebook.default_language
end
{:code, %{language: language}}
end
defp cell_type_and_attrs_from_params(%{"type" => "diagram"}, _socket) do
source = """
<!-- Learn more at https://mermaid-js.github.io/mermaid -->
@ -1920,7 +1929,7 @@ defmodule LivebookWeb.SessionLive do
{:markdown, %{source: source}}
end
defp cell_type_and_attrs_from_params(%{"type" => "image", "url" => url}) do
defp cell_type_and_attrs_from_params(%{"type" => "image", "url" => url}, _socket) do
source = "![](#{url})"
{:markdown, %{source: source}}

1
lib/livebook_web/live/session_live/insert_buttons_component.ex
View file

@ -23,7 +23,6 @@ defmodule LivebookWeb.SessionLive.InsertButtonsComponent do
class="pr-2"
phx-click="insert_cell_below"
phx-value-type="code"
phx-value-language={@default_language}
phx-value-section_id={@section_id}
phx-value-cell_id={@cell_id}
>