<.clients_list data_view={@data_view} client_id={@client_id} />
+
+ <.secrets_list data_view={@data_view} session={@session} socket={@socket} />
+
<.runtime_info data_view={@data_view} session={@session} socket={@socket} />
@@ -389,6 +397,16 @@ defmodule LivebookWeb.SessionLive do
) %>
<% end %>
+
+ <%= if @live_action == :secrets do %>
+ <.modal id="secrets-modal" show class="w-full max-w-4xl" patch={@self_path}>
+ <.live_component
+ module={LivebookWeb.SessionLive.SecretsComponent}
+ id="secrets"
+ session={@session}
+ />
+
+ <% end %>
"""
end
@@ -523,6 +541,32 @@ defmodule LivebookWeb.SessionLive do
"""
end
+ defp secrets_list(assigns) do
+ ~H"""
+
@@ -1572,7 +1616,8 @@ defmodule LivebookWeb.SessionLive do
installing?: data.cell_infos[Cell.setup_cell_id()].eval.status == :evaluating,
setup_cell_view: %{cell_to_view(hd(data.notebook.setup_section.cells), data) | type: :setup},
section_views: section_views(data.notebook.sections, data),
- bin_entries: data.bin_entries
+ bin_entries: data.bin_entries,
+ secrets: data.secrets
}
end
diff --git a/lib/livebook_web/live/session_live/secrets_component.ex b/lib/livebook_web/live/session_live/secrets_component.ex
new file mode 100644
index 000000000..88a2c2536
--- /dev/null
+++ b/lib/livebook_web/live/session_live/secrets_component.ex
@@ -0,0 +1,82 @@
+defmodule LivebookWeb.SessionLive.SecretsComponent do
+ use LivebookWeb, :live_component
+
+ @impl true
+ def mount(socket) do
+ {:ok, assign(socket, data: %{"label" => "", "value" => ""})}
+ end
+
+ @impl true
+ def update(assigns, socket) do
+ socket = assign(socket, assigns)
+ {:ok, socket}
+ end
+
+ @impl true
+ def render(assigns) do
+ ~H"""
+
+
+ Add secret
+
+
+
+ Enter the secret name and its value.
+
+ <.form
+ let={f}
+ for={:data}
+ phx-submit="save"
+ phx-change="validate"
+ autocomplete="off"
+ phx-target={@myself}
+ >
+
+
+
+ Label (alphanumeric and underscore)
+
+ <%= text_input(f, :label,
+ value: @data["label"],
+ class: "input",
+ placeholder: "secret label",
+ autofocus: true,
+ aria_labelledby: "secret-label",
+ spellcheck: "false"
+ ) %>
+
+
+
Value
+ <%= text_input(f, :value,
+ value: @data["value"],
+ class: "input",
+ placeholder: "secret value",
+ aria_labelledby: "secret-value",
+ spellcheck: "false"
+ ) %>
+
+
+
+
+
+
+ """
+ end
+
+ @impl true
+ def handle_event("save", %{"data" => data}, socket) do
+ secret = %{label: String.upcase(data["label"]), value: data["value"]}
+ Livebook.Session.put_secret(socket.assigns.session.pid, secret)
+ {:noreply, assign(socket, data: %{"label" => "", "value" => ""})}
+ end
+
+ def handle_event("validate", %{"data" => data}, socket) do
+ {:noreply, assign(socket, data: data)}
+ end
+
+ defp data_valid?(data) do
+ String.match?(data["label"], ~r/^\w+$/) and data["value"] != ""
+ end
+end
diff --git a/lib/livebook_web/live/session_live/shortcuts_component.ex b/lib/livebook_web/live/session_live/shortcuts_component.ex
index 8bda6f277..4b400be29 100644
--- a/lib/livebook_web/live/session_live/shortcuts_component.ex
+++ b/lib/livebook_web/live/session_live/shortcuts_component.ex
@@ -99,6 +99,7 @@ defmodule LivebookWeb.SessionLive.ShortcutsComponent do
%{seq: ["e", "x"], desc: "Cancel cell evaluation"},
%{seq: ["s", "s"], desc: "Toggle sections panel"},
%{seq: ["s", "u"], desc: "Toggle users panel"},
+ %{seq: ["s", "e"], desc: "Toggle secrets panel"},
%{seq: ["s", "r"], desc: "Show runtime panel"},
%{seq: ["s", "b"], desc: "Show bin"},
%{seq: ["s", "p"], desc: "Show package search"},
diff --git a/lib/livebook_web/router.ex b/lib/livebook_web/router.ex
index c8952bc0d..73d63aa85 100644
--- a/lib/livebook_web/router.ex
+++ b/lib/livebook_web/router.ex
@@ -60,6 +60,7 @@ defmodule LivebookWeb.Router do
live "/sessions/:id", SessionLive, :page
live "/sessions/:id/shortcuts", SessionLive, :shortcuts
+ live "/sessions/:id/secrets", SessionLive, :secrets
live "/sessions/:id/settings/runtime", SessionLive, :runtime_settings
live "/sessions/:id/settings/file", SessionLive, :file_settings
live "/sessions/:id/bin", SessionLive, :bin
diff --git a/test/livebook_web/live/session_live_test.exs b/test/livebook_web/live/session_live_test.exs
index 6c5da251d..e4c62f639 100644
--- a/test/livebook_web/live/session_live_test.exs
+++ b/test/livebook_web/live/session_live_test.exs
@@ -913,6 +913,18 @@ defmodule LivebookWeb.SessionLiveTest do
end
end
+ describe "add secret" do
+ test "adds a secret from form", %{conn: conn, session: session} do
+ {:ok, view, _} = live(conn, "/sessions/#{session.id}/secrets")
+
+ view
+ |> element(~s{form[phx-submit="save"]})
+ |> render_submit(%{data: %{label: "foo", value: "123"}})
+
+ assert %{secrets: [%{label: "FOO", value: "123"}]} = Session.get_data(session.pid)
+ end
+ end
+
# Helpers
defp wait_for_session_update(session_pid) do
diff --git a/test/support/noop_runtime.ex b/test/support/noop_runtime.ex
index 9bc3e72b7..6f39d7459 100644
--- a/test/support/noop_runtime.ex
+++ b/test/support/noop_runtime.ex
@@ -38,5 +38,7 @@ defmodule Livebook.Runtime.NoopRuntime do
end
def search_packages(_, _, _), do: make_ref()
+
+ def put_system_envs(_, _), do: :ok
end
end