livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-10-11 05:56:26 +08:00
Code Issues Projects Releases Packages Wiki Activity

Tiny fixes to names and conventions

Browse source
This commit is contained in:
José Valim 2024-04-07 11:31:43 +02:00
parent 08fa1b4f07
commit b1661da884
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/livebook_web/live/hub/teams/deployment_group_component.ex
View file

@ -53,8 +53,8 @@ defmodule LivebookWeb.Hub.Teams.DeploymentGroupComponent do
</div> </div>
<!-- Overview --> <!-- Overview -->
<div :if={@deployment_group.mode == :online} class="flex flex-col lg:flex-row justify-center"> <div :if={@deployment_group.mode == :online} class="flex flex-col lg:flex-row justify-center">
<.labeled_text class="grow mt-6 lg:border-l lg:pl-4" label="Instances running"> <.labeled_text class="grow mt-6 lg:border-l lg:pl-4" label="App servers">
<span class="text-lg font-normal" aria-label="instances running"> <span class="text-lg font-normal" aria-label="app servers">
<%= @agents_count %> <%= @agents_count %>
</span> </span>
<.link <.link
@ -84,13 +84,13 @@ defmodule LivebookWeb.Hub.Teams.DeploymentGroupComponent do
<a <a
href="#" href="#"
class="-ml-1 flex flex-row text-gray-500 text-sm" class="-ml-1 flex flex-row text-gray-500 text-sm"
phx-click={JS.toggle(to: "#secrets-group-#{@deployment_group.id} [data-toggler]")} phx-click={JS.toggle(to: "#secrets-group-#{@deployment_group.id} [data-toggle]")}
> >
<.remix_icon data-toggler icon="arrow-right-s-line" /> <.remix_icon data-toggle icon="arrow-right-s-line" />
<.remix_icon data-toggler icon="arrow-down-s-line hidden" /> <.remix_icon data-toggle icon="arrow-down-s-line hidden" />
<span class="pl-1">Additional secrets</span> <span class="pl-1">Additional secrets</span>
</a> </a>
<div data-toggler class="hidden text-sm flex space-y-4"> <div data-toggle class="hidden text-sm flex space-y-4">
<div class="flex flex-row space-x-2"> <div class="flex flex-row space-x-2">
<p class="grow text-gray-700"> <p class="grow text-gray-700">
Secrets that are exclusive to apps deployed to this group. Secrets that are exclusive to apps deployed to this group.

4
test/livebook_teams/web/hub/deployment_group_test.exs
View file

@ -220,7 +220,7 @@ defmodule LivebookWeb.Integration.Hub.DeploymentGroupTest do
{:ok, view, _html} = live(conn, ~p"/hub/#{hub.id}") {:ok, view, _html} = live(conn, ~p"/hub/#{hub.id}")
assert view assert view
|> element("#hub-deployment-group-#{id} [aria-label=\"instances running\"]") |> element("#hub-deployment-group-#{id} [aria-label=\"app servers\"]")
|> render() |> render()
|> Floki.parse_fragment!() |> Floki.parse_fragment!()
|> Floki.text() |> Floki.text()
@ -245,7 +245,7 @@ defmodule LivebookWeb.Integration.Hub.DeploymentGroupTest do
assert_receive {:agent_joined, ^agent} assert_receive {:agent_joined, ^agent}
assert view assert view
|> element("#hub-deployment-group-#{id} [aria-label=\"instances running\"]") |> element("#hub-deployment-group-#{id} [aria-label=\"app servers\"]")
|> render() |> render()
|> Floki.parse_fragment!() |> Floki.parse_fragment!()
|> Floki.text() |> Floki.text()