livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-10-11 05:56:26 +08:00
Code Issues Projects Releases Packages Wiki Activity

Improves cell accessibility (#1009)

Browse source 
* Reads the output after a cell has been evaluated

* Creates SR landmarks when errors happen

* fixes formatting

* Reads a clearer message when a runtime restart is required

* Update lib/livebook_web/live/session_live/cell_component.ex

Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>

Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
This commit is contained in:
Cristine Guadelupe 2022-02-17 19:37:14 -03:00 • committed by GitHub
parent 8055858381
commit b32b363ed1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/livebook_web/live/output.ex
View file

@ -94,7 +94,7 @@ defmodule LivebookWeb.Output do
assigns = %{formatted: formatted, is_standalone: Livebook.Runtime.standalone?(runtime)} assigns = %{formatted: formatted, is_standalone: Livebook.Runtime.standalone?(runtime)}
~H""" ~H"""
<div class="flex flex-col space-y-4"> <div class="flex flex-col space-y-4" role="complementary" aria-label="runtime restart required">
<%= render_error(@formatted) %> <%= render_error(@formatted) %>
<%= if @is_standalone do %> <%= if @is_standalone do %>
<div> <div>
@ -142,7 +142,7 @@ defmodule LivebookWeb.Output do
assigns = %{message: message} assigns = %{message: message}
~H""" ~H"""
<div class="whitespace-pre-wrap font-editor text-gray-500"><%= ansi_string_to_html(@message) %></div> <div class="whitespace-pre-wrap font-editor text-gray-500" role="complementary" aria-label="error"><%= ansi_string_to_html(@message) %></div>
""" """
end end
@ -150,7 +150,7 @@ defmodule LivebookWeb.Output do
assigns = %{message: message} assigns = %{message: message}
~H""" ~H"""
<div class="whitespace-pre-wrap font-editor text-red-600"><%= @message %></div> <div class="whitespace-pre-wrap font-editor text-red-600" role="complementary" aria-label="error message"><%= @message %></div>
""" """
end end
end end

1
lib/livebook_web/live/session_live/cell_component.ex
View file

@ -137,6 +137,7 @@ defmodule LivebookWeb.SessionLive.CellComponent do
<.cell_body> <.cell_body>
<.editor cell_view={@cell_view} /> <.editor cell_view={@cell_view} />
<div class="flex flex-col" <div class="flex flex-col"
aria-live="polite"
data-element="outputs-container" data-element="outputs-container"
id={"outputs-#{@cell_view.id}-#{@cell_view.outputs_batch_number}"} id={"outputs-#{@cell_view.id}-#{@cell_view.outputs_batch_number}"}
phx-update="append"> phx-update="append">