Fix editor escape in Vim visual mode (#2178)

Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>

assets/js/hooks/cell_editor/live_editor.js

@@ -371,16 +371,7 @@ class LiveEditor {
     this._initializeWidgets();
 
     // Set the editor mode
-    if (settings.editor_mode == "emacs") {
+    this._setEditorMode(settings.editor_mode);
-      this.emacsMode = new EmacsExtension(this.editor);
-      this.emacsMode.start();
-      unregisterKey("Tab");
-    } else if (settings.editor_mode == "vim") {
-      this.vimMode = initVimMode(this.editor);
-      this.vimMode.on("vim-mode-change", ({ mode: mode }) => {
-        this.editor.getDomNode().setAttribute("data-vim-mode", mode);
-      });
-    }
   }
 
   /**
@@ -646,6 +637,22 @@ class LiveEditor {
       );
     });
   }
+
+  /**
+   * Sets Monaco editor mode via monaco-emacs or monaco-vim packages.
+   */
+  _setEditorMode(editorMode) {
+    if (editorMode == "emacs") {
+      this.emacsMode = new EmacsExtension(this.editor);
+      this.emacsMode.start();
+      unregisterKey("Tab");
+    } else if (editorMode == "vim") {
+      this.vimMode = initVimMode(this.editor);
+      this.vimMode.on("vim-mode-change", ({ mode: mode }) => {
+        this.editor.getDomNode().setAttribute("data-vim-mode", mode);
+      });
+    }
+  }
 }
 
 function completionItemsToSuggestions(items, settings) {

assets/js/hooks/session.js

@@ -469,8 +469,8 @@ const Session = {
       return true;
     }
 
-    // Vim insert mode
+    // Vim insert or visual mode
-    if (editor.dataset.vimMode == "insert") {
+    if (["insert", "visual"].includes(editor.dataset.vimMode)) {
       return true;
     }