From c473a8c46957feb4ec72fcd3efcf77412c29255d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jonatan=20K=C5=82osko?= <jonatanklosko@gmail.com>
Date: Tue, 9 Nov 2021 10:45:05 +0100
Subject: [PATCH] Add an option to amplify cell outputs (#689)

* Add an option to amplify cell outputs

* Reorder actions
---
 assets/css/js_interop.css                           |  8 ++++++++
 assets/js/cell/index.js                             | 10 ++++++++++
 .../live/session_live/cell_component.ex             | 13 +++++++++----
 3 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/assets/css/js_interop.css b/assets/css/js_interop.css
index 3caf518cf..8b5f1c92c 100644
--- a/assets/css/js_interop.css
+++ b/assets/css/js_interop.css
@@ -86,6 +86,14 @@ solely client-side operations.
   @apply bg-blue-300;
 }
 
+[data-element="cell"][data-js-amplified] [data-element="outputs-container"] {
+  @apply bg-white m-0 py-16;
+
+  width: 90vw;
+  position: relative;
+  left: calc(-45vw + 50%);
+}
+
 [data-element="session"]:not([data-js-side-panel-content])
   [data-element="side-panel"] {
   @apply hidden;
diff --git a/assets/js/cell/index.js b/assets/js/cell/index.js
index a99442d04..f01bb2ffb 100644
--- a/assets/js/cell/index.js
+++ b/assets/js/cell/index.js
@@ -49,6 +49,16 @@ const Cell = {
           revision
         );
 
+        // Setup action handlers
+        if (this.props.type === "elixir") {
+          const amplifyButton = this.el.querySelector(
+            `[data-element="amplify-outputs-button"]`
+          );
+          amplifyButton.addEventListener("click", (event) => {
+            this.el.toggleAttribute("data-js-amplified");
+          });
+        }
+
         // Setup change indicator
         if (this.props.type === "elixir") {
           this.state.evaluationDigest = evaluation_digest;
diff --git a/lib/livebook_web/live/session_live/cell_component.ex b/lib/livebook_web/live/session_live/cell_component.ex
index c7fba6210..820f9f10a 100644
--- a/lib/livebook_web/live/session_live/cell_component.ex
+++ b/lib/livebook_web/live/session_live/cell_component.ex
@@ -20,7 +20,6 @@ defmodule LivebookWeb.SessionLive.CellComponent do
     ~H"""
     <div class="mb-1 flex items-center justify-end">
       <div class="relative z-20 flex items-center justify-end space-x-2" data-element="actions">
-        <.cell_link_button cell_id={@cell_view.id} />
         <span class="tooltip top" data-tooltip="Edit content" data-element="enable-insert-mode-button">
           <button class="icon-button" aria-label="edit content">
             <.remix_icon icon="pencil-line" class="text-xl" />
@@ -33,6 +32,7 @@ defmodule LivebookWeb.SessionLive.CellComponent do
             <.remix_icon icon="image-add-line" class="text-xl" />
           <% end %>
         </span>
+        <.cell_link_button cell_id={@cell_view.id} />
         <.move_cell_up_button cell_id={@cell_view.id} />
         <.move_cell_down_button cell_id={@cell_view.id} />
         <.delete_cell_button cell_id={@cell_view.id} />
@@ -88,8 +88,13 @@ defmodule LivebookWeb.SessionLive.CellComponent do
         <% end %>
       </div>
       <div class="relative z-20 flex items-center justify-end space-x-2" data-element="actions">
-        <.cell_link_button cell_id={@cell_view.id} />
+        <span class="tooltip top" data-tooltip="Amplify output" data-element="amplify-outputs-button">
+          <button class="icon-button" aria-label="amplify outputs">
+            <.remix_icon icon="zoom-in-line" class="text-xl" />
+          </button>
+        </span>
         <.cell_settings_button cell_id={@cell_view.id} socket={@socket} session_id={@session_id} />
+        <.cell_link_button cell_id={@cell_view.id} />
         <.move_cell_up_button cell_id={@cell_view.id} />
         <.move_cell_down_button cell_id={@cell_view.id} />
         <.delete_cell_button cell_id={@cell_view.id} />
@@ -100,7 +105,7 @@ defmodule LivebookWeb.SessionLive.CellComponent do
       <.editor cell_view={@cell_view} />
 
       <%= if @cell_view.outputs != [] do %>
-        <div class="mt-2">
+        <div class="mt-2" data-element="outputs-container">
           <.outputs cell_view={@cell_view} runtime={@runtime} socket={@socket} />
         </div>
       <% end %>
@@ -112,8 +117,8 @@ defmodule LivebookWeb.SessionLive.CellComponent do
     ~H"""
     <div class="mb-1 flex items-center justify-end">
       <div class="relative z-20 flex items-center justify-end space-x-2" data-element="actions">
-        <.cell_link_button cell_id={@cell_view.id} />
         <.cell_settings_button cell_id={@cell_view.id} socket={@socket} session_id={@session_id} />
+        <.cell_link_button cell_id={@cell_view.id} />
         <.move_cell_up_button cell_id={@cell_view.id} />
         <.move_cell_down_button cell_id={@cell_view.id} />
         <.delete_cell_button cell_id={@cell_view.id} />