livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-10-24 20:36:26 +08:00
Code Issues Projects Releases Packages Wiki Activity

Show cell evaluation time also when stale and aborted

Browse source
This commit is contained in:
Jonatan Kłosko 2024-02-15 15:46:57 +07:00
parent f9f744ad80
commit cc92a6d03b
1 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
lib/livebook_web/live/session_live/cell_component.ex
View file

@ -704,7 +704,7 @@ defmodule LivebookWeb.SessionLive.CellComponent do
<.cell_status_indicator <.cell_status_indicator
variant={if(@cell_view.eval.errored, do: :error, else: :success)} variant={if(@cell_view.eval.errored, do: :error, else: :success)}
change_indicator={true} change_indicator={true}
tooltip={evaluated_label(@cell_view.eval.evaluation_time_ms)} tooltip={duration_label(@cell_view.eval.evaluation_time_ms)}
> >
Evaluated Evaluated
</.cell_status_indicator> </.cell_status_indicator>
@ -713,7 +713,11 @@ defmodule LivebookWeb.SessionLive.CellComponent do
defp cell_status(%{cell_view: %{eval: %{validity: :stale}}} = assigns) do defp cell_status(%{cell_view: %{eval: %{validity: :stale}}} = assigns) do
~H""" ~H"""
<.cell_status_indicator variant={:warning} change_indicator={true}> <.cell_status_indicator
variant={:warning}
change_indicator={true}
tooltip={duration_label(@cell_view.eval.evaluation_time_ms)}
>
Stale Stale
</.cell_status_indicator> </.cell_status_indicator>
""" """
@ -721,7 +725,10 @@ defmodule LivebookWeb.SessionLive.CellComponent do
defp cell_status(%{cell_view: %{eval: %{validity: :aborted}}} = assigns) do defp cell_status(%{cell_view: %{eval: %{validity: :aborted}}} = assigns) do
~H""" ~H"""
<.cell_status_indicator variant={:inactive}> <.cell_status_indicator
variant={:inactive}
tooltip={duration_label(@cell_view.eval.evaluation_time_ms)}
>
Aborted Aborted
</.cell_status_indicator> </.cell_status_indicator>
""" """
@ -749,7 +756,7 @@ defmodule LivebookWeb.SessionLive.CellComponent do
""" """
end end
defp evaluated_label(time_ms) when is_integer(time_ms) do defp duration_label(time_ms) when is_integer(time_ms) do
evaluation_time = evaluation_time =
if time_ms > 100 do if time_ms > 100 do
seconds = time_ms |> Kernel./(1000) |> Float.floor(1) seconds = time_ms |> Kernel./(1000) |> Float.floor(1)
@ -761,7 +768,7 @@ defmodule LivebookWeb.SessionLive.CellComponent do
"Took " <> evaluation_time "Took " <> evaluation_time
end end
defp evaluated_label(_time_ms), do: nil defp duration_label(_time_ms), do: nil
defp smart_cell_js_view_ref(%{type: :smart, status: :started, js_view: %{ref: ref}}), do: ref defp smart_cell_js_view_ref(%{type: :smart, status: :started, js_view: %{ref: ref}}), do: ref
defp smart_cell_js_view_ref(_cell_view), do: nil defp smart_cell_js_view_ref(_cell_view), do: nil