livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-10-07 20:16:31 +08:00
Code Issues Projects Releases Packages Wiki Activity

Improve unlisted error when there is no files/ directory

Browse source
This commit is contained in:
José Valim 2023-08-10 20:54:07 +02:00
parent e26d45ac46
commit d0ef0e0279
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
lib/livebook_web/live/session_live/add_file_entry_unlisted_component.ex
View file

@ -16,7 +16,7 @@ defmodule LivebookWeb.SessionLive.AddFileEntryUnlistedComponent do
|> assign_new(:files, fn -> |> assign_new(:files, fn ->
case FileSystem.File.list(assigns.session.files_dir) do case FileSystem.File.list(assigns.session.files_dir) do
{:ok, files} -> unlisted_files(files, assigns.file_entries) {:ok, files} -> unlisted_files(files, assigns.file_entries)
{:error, _} -> [] {:error, _} -> :none
end end
end) end)
@ -37,12 +37,16 @@ defmodule LivebookWeb.SessionLive.AddFileEntryUnlistedComponent do
@impl true @impl true
def render(assigns) do def render(assigns) do
~H""" ~H"""
<div class="flex flex-col"> <div>
<%= if @files == [] do %> <p :if={@files == :none} class="text-gray-700">
<p class="text-gray-700"> There is no <code>files/</code> directory that exists alongside your notebook.
No other files found in the <code>files/</code> directory. </p>
</p>
<% else %> <p :if={@files == []} class="text-gray-700">
No other files found in the <code>files/</code> directory.
</p>
<div :if={match?([_ | _], @files)} class="flex flex-col">
<p class="text-gray-700"> <p class="text-gray-700">
Here are other files from the <code>files/</code> directory that you may want to add. Here are other files from the <code>files/</code> directory that you may want to add.
</p> </p>
@ -77,7 +81,7 @@ defmodule LivebookWeb.SessionLive.AddFileEntryUnlistedComponent do
</.link> </.link>
</div> </div>
</form> </form>
<% end %> </div>
</div> </div>
""" """
end end