From db6fbbd1a835d66919c7fcc625f95d7f2b9c5637 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonatan=20K=C5=82osko?= Date: Mon, 26 Aug 2024 20:20:33 +0900 Subject: [PATCH] Fix long module definition name overflowing --- .../live/session_live/app_info_component.ex | 2 +- .../live/session_live/files_list_component.ex | 2 +- lib/livebook_web/live/session_live/render.ex | 74 ++++++++----------- .../session_live/secrets_list_component.ex | 2 +- 4 files changed, 34 insertions(+), 46 deletions(-) diff --git a/lib/livebook_web/live/session_live/app_info_component.ex b/lib/livebook_web/live/session_live/app_info_component.ex index 84f4fb0f5..8f7d1e694 100644 --- a/lib/livebook_web/live/session_live/app_info_component.ex +++ b/lib/livebook_web/live/session_live/app_info_component.ex @@ -6,7 +6,7 @@ defmodule LivebookWeb.SessionLive.AppInfoComponent do @impl true def render(assigns) do ~H""" -
+

App diff --git a/lib/livebook_web/live/session_live/files_list_component.ex b/lib/livebook_web/live/session_live/files_list_component.ex index 74b013aee..3b31cbc0a 100644 --- a/lib/livebook_web/live/session_live/files_list_component.ex +++ b/lib/livebook_web/live/session_live/files_list_component.ex @@ -25,7 +25,7 @@ defmodule LivebookWeb.SessionLive.FilesListComponent do @impl true def render(assigns) do ~H""" -
+

Files

diff --git a/lib/livebook_web/live/session_live/render.ex b/lib/livebook_web/live/session_live/render.ex index 8247036c6..5462c336b 100644 --- a/lib/livebook_web/live/session_live/render.ex +++ b/lib/livebook_web/live/session_live/render.ex @@ -419,46 +419,34 @@ defmodule LivebookWeb.SessionLive.Render do class="flex flex-col h-full w-full max-w-xs absolute z-30 top-0 left-[64px] overflow-y-auto shadow-xl md:static md:shadow-none bg-gray-50 border-r border-gray-100 px-6 pt-16 md:py-8" data-el-side-panel > -
- <.outline_list data_view={@data_view} /> -
-
- <.clients_list data_view={@data_view} client_id={@client_id} /> -
-
- <.live_component - module={LivebookWeb.SessionLive.FilesListComponent} - id="files-list" - session={@session} - file_entries={@data_view.file_entries} - quarantine_file_entry_names={@data_view.quarantine_file_entry_names} - /> -
-
- <.live_component - module={LivebookWeb.SessionLive.SecretsListComponent} - id="secrets-list" - session={@session} - secrets={@data_view.secrets} - hub_secrets={@data_view.hub_secrets} - hub={@data_view.hub} - /> -
-
- <.live_component - module={LivebookWeb.SessionLive.AppInfoComponent} - id="app-info" - session={@session} - settings={@data_view.app_settings} - app={@app} - deployed_app_slug={@data_view.deployed_app_slug} - any_session_secrets?={@data_view.any_session_secrets?} - hub={@data_view.hub} - /> -
-
- <.runtime_info data_view={@data_view} session={@session} /> -
+ <.outline_list data_view={@data_view} /> + <.clients_list data_view={@data_view} client_id={@client_id} /> + <.live_component + module={LivebookWeb.SessionLive.FilesListComponent} + id="files-list" + session={@session} + file_entries={@data_view.file_entries} + quarantine_file_entry_names={@data_view.quarantine_file_entry_names} + /> + <.live_component + module={LivebookWeb.SessionLive.SecretsListComponent} + id="secrets-list" + session={@session} + secrets={@data_view.secrets} + hub_secrets={@data_view.hub_secrets} + hub={@data_view.hub} + /> + <.live_component + module={LivebookWeb.SessionLive.AppInfoComponent} + id="app-info" + session={@session} + settings={@data_view.app_settings} + app={@app} + deployed_app_slug={@data_view.deployed_app_slug} + any_session_secrets?={@data_view.any_session_secrets?} + hub={@data_view.hub} + /> + <.runtime_info data_view={@data_view} session={@session} />
""" end @@ -499,7 +487,7 @@ defmodule LivebookWeb.SessionLive.Render do defp outline_list(assigns) do ~H""" -
+

Outline

@@ -582,7 +570,7 @@ defmodule LivebookWeb.SessionLive.Render do defp clients_list(assigns) do ~H""" -
+

Users @@ -645,7 +633,7 @@ defmodule LivebookWeb.SessionLive.Render do defp runtime_info(assigns) do ~H""" -
+

Runtime diff --git a/lib/livebook_web/live/session_live/secrets_list_component.ex b/lib/livebook_web/live/session_live/secrets_list_component.ex index d9b2d4ff5..58d3b9fec 100644 --- a/lib/livebook_web/live/session_live/secrets_list_component.ex +++ b/lib/livebook_web/live/session_live/secrets_list_component.ex @@ -6,7 +6,7 @@ defmodule LivebookWeb.SessionLive.SecretsListComponent do @impl true def render(assigns) do ~H""" -
+

Secrets