From dbab38a7639fd0e8b5bf226bb19a7fd7bcd96a6b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jonatan=20K=C5=82osko?= <jonatanklosko@gmail.com>
Date: Tue, 28 Mar 2023 17:41:22 +0100
Subject: [PATCH] Show app URLs as relative (#1835)

---
 lib/livebook_web.ex                                      | 4 ++++
 lib/livebook_web/live/apps_live.ex                       | 4 ++--
 lib/livebook_web/live/session_live/app_info_component.ex | 4 ++--
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/lib/livebook_web.ex b/lib/livebook_web.ex
index 083c7faa8..4613f2dfb 100644
--- a/lib/livebook_web.ex
+++ b/lib/livebook_web.ex
@@ -80,6 +80,10 @@ defmodule LivebookWeb do
         endpoint: LivebookWeb.Endpoint,
         router: LivebookWeb.Router,
         statics: LivebookWeb.static_paths()
+
+      # We don't know the hostname Livebook runs on, so we don't use
+      # absolute URL helpers
+      import Phoenix.VerifiedRoutes, only: :sigils
     end
   end
 
diff --git a/lib/livebook_web/live/apps_live.ex b/lib/livebook_web/live/apps_live.ex
index 0b0f78684..e4f1c2954 100644
--- a/lib/livebook_web/live/apps_live.ex
+++ b/lib/livebook_web/live/apps_live.ex
@@ -89,8 +89,8 @@ defmodule LivebookWeb.AppsLive do
         <div class="flex-1 grow-[2]">
           <.labeled_text label="URL">
             <%= if @session.app_info.registered do %>
-              <a href={url(~p"/apps/#{@session.app_info.slug}")} target="_blank">
-                <%= url(~p"/apps/#{@session.app_info.slug}") %>
+              <a href={~p"/apps/#{@session.app_info.slug}"} target="_blank">
+                <%= ~p"/apps/#{@session.app_info.slug}" %>
               </a>
             <% else %>
               -
diff --git a/lib/livebook_web/live/session_live/app_info_component.ex b/lib/livebook_web/live/session_live/app_info_component.ex
index 0d48ee5eb..7407e3324 100644
--- a/lib/livebook_web/live/session_live/app_info_component.ex
+++ b/lib/livebook_web/live/session_live/app_info_component.ex
@@ -112,8 +112,8 @@ defmodule LivebookWeb.SessionLive.AppInfoComponent do
               </.labeled_text>
               <.labeled_text label="URL" one_line>
                 <%= if app.registered do %>
-                  <a href={url(~p"/apps/#{app.settings.slug}")} target="_blank">
-                    <%= url(~p"/apps/#{app.settings.slug}") %>
+                  <a href={~p"/apps/#{app.settings.slug}"} target="_blank">
+                    <%= ~p"/apps/#{app.settings.slug}" %>
                   </a>
                 <% else %>
                   -