Home tests (#118)

* Test forking existing session

* Test session deletion

* Fix capitalization

lib/livebook_web/live/delete_session_component.ex

@@ -31,6 +31,6 @@ defmodule LivebookWeb.DeleteSessionComponent do
   @impl true
   def handle_event("delete", %{}, socket) do
     SessionSupervisor.delete_session(socket.assigns.session_summary.session_id)
-    {:noreply, push_redirect(socket, to: socket.assigns.return_to)}
+    {:noreply, push_patch(socket, to: socket.assigns.return_to)}
   end
 end

lib/livebook_web/live/home_live.ex

@@ -38,7 +38,7 @@ defmodule LivebookWeb.HomeLive do
             </div>
             <button class="button button-blue"
               phx-click="new">
-              New Notebook
+              New notebook
             </button>
           </div>
           <div class="w-full h-80">
@@ -70,7 +70,7 @@ defmodule LivebookWeb.HomeLive do
           </div>
           <div class="w-full py-12">
             <h3 class="text-xl font-semibold text-gray-800 mb-5">
-              Running Sessions
+              Running sessions
             </h3>
             <%= if @session_summaries == [] do %>
               <div class="p-5 flex space-x-4 items-center border border-gray-200 rounded-lg">
@@ -80,7 +80,7 @@ defmodule LivebookWeb.HomeLive do
                 <div class="text-gray-600">
                   You do not have any running sessions.
                   <br>
-                  Please create a new one by clicking <span class="font-semibold">“New Notebook”</span>
+                  Please create a new one by clicking <span class="font-semibold">“New notebook”</span>
                 </div>
               </div>
             <% else %>
@@ -125,6 +125,12 @@ defmodule LivebookWeb.HomeLive do
     create_session(socket, notebook: notebook, path: socket.assigns.path)
   end
 
+  def handle_event("fork_session", %{"id" => session_id}, socket) do
+    data = Session.get_data(session_id)
+    notebook = %{data.notebook | name: data.notebook.name <> " - fork"}
+    create_session(socket, notebook: notebook)
+  end
+
   @impl true
   def handle_info({:session_created, id}, socket) do
     summary = Session.get_summary(id)
@@ -137,12 +143,6 @@ defmodule LivebookWeb.HomeLive do
     {:noreply, assign(socket, session_summaries: session_summaries)}
   end
 
-  def handle_info({:fork_session, id}, socket) do
-    data = Session.get_data(id)
-    notebook = %{data.notebook | name: data.notebook.name <> " - fork"}
-    create_session(socket, notebook: notebook)
-  end
-
   def handle_info(_message, socket), do: {:noreply, socket}
 
   defp default_path(), do: File.cwd!() <> "/"

lib/livebook_web/live/sessions_component.ex

@@ -1,14 +1,13 @@
 defmodule LivebookWeb.SessionsComponent do
   use LivebookWeb, :live_component
 
-  alias Livebook.SessionSupervisor
-
   @impl true
   def render(assigns) do
     ~L"""
     <div class="flex flex-col space-y-4">
       <%= for summary <- @session_summaries do %>
-        <div class="p-5 flex items-center border border-gray-200 rounded-lg">
+        <div class="p-5 flex items-center border border-gray-200 rounded-lg"
+          data-test-session-id="<%= summary.session_id %>">
           <div class="flex-grow flex flex-col space-y-1">
             <%= live_redirect summary.notebook_name, to: Routes.session_path(@socket, :page, summary.session_id),
               class: "font-semibold text-gray-800 hover:text-gray-900" %>
@@ -23,8 +22,7 @@ defmodule LivebookWeb.SessionsComponent do
             <div class="absolute right-0 z-20 rounded-lg shadow-center bg-white flex flex-col py-2" data-element="menu">
               <button class="flex space-x-3 px-5 py-2 items-center text-gray-500 hover:bg-gray-50"
                 phx-click="fork_session"
-                phx-value-id="<%= summary.session_id %>"
-                phx-target="<%= @myself %>">
+                phx-value-id="<%= summary.session_id %>">
                 <%= remix_icon("git-branch-line") %>
                 <span class="font-medium">Fork</span>
               </button>
@@ -40,15 +38,4 @@ defmodule LivebookWeb.SessionsComponent do
     </div>
     """
   end
-
-  @impl true
-  def handle_event("delete_session", %{"id" => session_id}, socket) do
-    SessionSupervisor.delete_session(session_id)
-    {:noreply, socket}
-  end
-
-  def handle_event("fork_session", %{"id" => session_id}, socket) do
-    send(self(), {:fork_session, session_id})
-    {:noreply, socket}
-  end
 end

test/livebook_web/live/home_live_test.exs

@@ -3,12 +3,12 @@ defmodule LivebookWeb.HomeLiveTest do
 
   import Phoenix.LiveViewTest
 
-  alias Livebook.SessionSupervisor
+  alias Livebook.{SessionSupervisor, Session}
 
   test "disconnected and connected render", %{conn: conn} do
     {:ok, view, disconnected_html} = live(conn, "/")
-    assert disconnected_html =~ "Running Sessions"
-    assert render(view) =~ "Running Sessions"
+    assert disconnected_html =~ "Running sessions"
+    assert render(view) =~ "Running sessions"
   end
 
   test "redirects to session upon creation", %{conn: conn} do
@@ -16,7 +16,7 @@ defmodule LivebookWeb.HomeLiveTest do
 
     assert {:error, {:live_redirect, %{to: to}}} =
              view
-             |> element("button", "New Notebook")
+             |> element("button", "New notebook")
              |> render_click()
 
     assert to =~ "/sessions/"
@@ -99,6 +99,41 @@ defmodule LivebookWeb.HomeLiveTest do
       SessionSupervisor.delete_session(id)
       refute render(view) =~ id
     end
+
+    test "allows forking existing session", %{conn: conn} do
+      {:ok, id} = SessionSupervisor.create_session()
+      Session.set_notebook_name(id, "My notebook")
+
+      {:ok, view, _} = live(conn, "/")
+
+      assert {:error, {:live_redirect, %{to: to}}} =
+               view
+               |> element(~s{[data-test-session-id="#{id}"] button}, "Fork")
+               |> render_click()
+
+      assert to =~ "/sessions/"
+
+      {:ok, view, _} = live(conn, to)
+      assert render(view) =~ "My notebook - fork"
+    end
+
+    test "allows deleting session after confirmation", %{conn: conn} do
+      {:ok, id} = SessionSupervisor.create_session()
+
+      {:ok, view, _} = live(conn, "/")
+
+      assert render(view) =~ id
+
+      view
+      |> element(~s{[data-test-session-id="#{id}"] a}, "Delete")
+      |> render_click()
+
+      view
+      |> element(~s{button}, "Delete session")
+      |> render_click()
+
+      refute render(view) =~ id
+    end
   end
 
   # Helpers