livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-09-14 08:54:35 +08:00
Code Issues Projects Releases Packages Wiki Activity

Reinitialize JS views on reconnection (#1270)

Browse source
This commit is contained in:
Jonatan Kłosko 2022-07-11 20:19:32 +01:00 • committed by GitHub
parent a4e645defa
commit e82279d9af
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
assets/js/hooks/js_view.js
View file

@ -146,6 +146,11 @@ const JSView = {
this.props = this.getProps(this); this.props = this.getProps(this);
}, },
disconnected() {
// Reinitialize on reconnection
this.el.removeAttribute("id");
},
destroyed() { destroyed() {
window.removeEventListener("message", this._handleWindowMessage); window.removeEventListener("message", this._handleWindowMessage);

8
assets/js/hooks/session.js
View file

@ -233,6 +233,10 @@ const Session = {
disconnected() { disconnected() {
// Reinitialize on reconnection // Reinitialize on reconnection
this.el.removeAttribute("id"); this.el.removeAttribute("id");
// If we reconnect, a new hook is mounted and it becomes responsible
// for leaving the channel when destroyed
this.keepChannel = true;
}, },
destroyed() { destroyed() {
@ -246,7 +250,9 @@ const Session = {
setFavicon("favicon"); setFavicon("favicon");
leaveChannel(); if (!this.keepChannel) {
leaveChannel();
}
}, },
getProps() { getProps() {