Add spinners for long file actions (#2113)

assets/css/components.css

@@ -2,7 +2,7 @@
   /* Buttons */
 
   .button-base {
-    @apply inline-flex px-5 py-2 rounded-lg border border-transparent font-medium text-sm whitespace-nowrap;
+    @apply inline-flex items-center px-5 py-2 rounded-lg border border-transparent font-medium text-sm whitespace-nowrap;
   }
 
   .button-blue {

lib/livebook_web/components/core_components.ex

@@ -597,6 +597,35 @@ defmodule LivebookWeb.CoreComponents do
     """
   end
 
+  @doc """
+  Renders a circular spinner.
+  """
+
+  attr :class, :string, default: nil
+  attr :rest, :global
+
+  def spinner(assigns) do
+    ~H"""
+    <svg
+      aria-hidden="true"
+      class={["inline w-4 h-4 text-gray-200 animate-spin fill-blue-600", @class]}
+      viewBox="0 0 100 101"
+      fill="none"
+      xmlns="http://www.w3.org/2000/svg"
+      {@rest}
+    >
+      <path
+        d="M100 50.5908C100 78.2051 77.6142 100.591 50 100.591C22.3858 100.591 0 78.2051 0 50.5908C0 22.9766 22.3858 0.59082 50 0.59082C77.6142 0.59082 100 22.9766 100 50.5908ZM9.08144 50.5908C9.08144 73.1895 27.4013 91.5094 50 91.5094C72.5987 91.5094 90.9186 73.1895 90.9186 50.5908C90.9186 27.9921 72.5987 9.67226 50 9.67226C27.4013 9.67226 9.08144 27.9921 9.08144 50.5908Z"
+        fill="currentColor"
+      />
+      <path
+        d="M93.9676 39.0409C96.393 38.4038 97.8624 35.9116 97.0079 33.5539C95.2932 28.8227 92.871 24.3692 89.8167 20.348C85.8452 15.1192 80.8826 10.7238 75.2124 7.41289C69.5422 4.10194 63.2754 1.94025 56.7698 1.05124C51.7666 0.367541 46.6976 0.446843 41.7345 1.27873C39.2613 1.69328 37.813 4.19778 38.4501 6.62326C39.0873 9.04874 41.5694 10.4717 44.0505 10.1071C47.8511 9.54855 51.7191 9.52689 55.5402 10.0491C60.8642 10.7766 65.9928 12.5457 70.6331 15.2552C75.2735 17.9648 79.3347 21.5619 82.5849 25.841C84.9175 28.9121 86.7997 32.2913 88.1811 35.8758C89.083 38.2158 91.5421 39.6781 93.9676 39.0409Z"
+        fill="currentFill"
+      />
+    </svg>
+    """
+  end
+
   @doc """
   Returns the text in singular or plural depending on the quantity.
 

lib/livebook_web/live/session_live/add_file_entry_file_component.ex

@@ -94,7 +94,8 @@ defmodule LivebookWeb.SessionLive.AddFileEntryFileComponent do
             type="submit"
             disabled={not @changeset.valid? or not regular?(@file, @file_info) or @fetching}
           >
-            Add
+            <.spinner :if={@fetching} class="mr-2" />
+            <span>Add</span>
           </button>
           <.link patch={~p"/sessions/#{@session.id}"} class="button-base button-outlined-gray">
             Cancel

lib/livebook_web/live/session_live/add_file_entry_upload_component.ex

@@ -68,7 +68,8 @@ defmodule LivebookWeb.SessionLive.AddFileEntryUploadComponent do
             type="submit"
             disabled={not @changeset.valid? or upload_disabled?(@uploads.file)}
           >
-            Add
+            <.spinner class="hidden phx-submit-loading:block mr-2" />
+            <span>Add</span>
           </button>
           <.link patch={~p"/sessions/#{@session.id}"} class="button-base button-outlined-gray">
             Cancel

lib/livebook_web/live/session_live/add_file_entry_url_component.ex

@@ -68,7 +68,8 @@ defmodule LivebookWeb.SessionLive.AddFileEntryUrlComponent do
             type="submit"
             disabled={not @changeset.valid? or @fetching}
           >
-            Add
+            <.spinner :if={@fetching} class="mr-2" />
+            <span>Add</span>
           </button>
           <.link patch={~p"/sessions/#{@session.id}"} class="button-base button-outlined-gray">
             Cancel

lib/livebook_web/live/session_live/files_list_component.ex

@@ -4,7 +4,12 @@ defmodule LivebookWeb.SessionLive.FilesListComponent do
   alias Livebook.FileSystem
 
   @impl true
-  def update(%{transfer_file_entry_result: file_entry_result}, socket) do
+  def mount(socket) do
+    {:ok, assign(socket, transferring_file_entry_names: MapSet.new())}
+  end
+
+  @impl true
+  def update(%{transfer_file_entry_result: {name, file_entry_result}}, socket) do
     case file_entry_result do
       {:ok, file_entry} ->
         Livebook.Session.add_file_entries(socket.assigns.session.pid, [file_entry])
@@ -13,6 +18,8 @@ defmodule LivebookWeb.SessionLive.FilesListComponent do
         send(self(), {:put_flash, :error, Livebook.Utils.upcase_first(message)})
     end
 
+    socket = update(socket, :transferring_file_entry_names, &MapSet.delete(&1, name))
+
     {:ok, socket}
   end
 
@@ -65,56 +72,63 @@ defmodule LivebookWeb.SessionLive.FilesListComponent do
               <span class="break-all"><%= file_entry.name %></span>
             </div>
           <% end %>
-          <.menu id={"file-entry-#{idx}-menu"} position={:bottom_right}>
-            <:toggle>
-              <button class="icon-button" aria-label="menu">
-                <.remix_icon icon="more-2-line" />
-              </button>
-            </:toggle>
-            <.menu_item>
-              <button
-                :if={file_entry.type != :attachment}
-                role="menuitem"
-                phx-click={
-                  JS.push("transfer_file_entry", value: %{name: file_entry.name}, target: @myself)
-                }
-              >
-                <.remix_icon icon="file-transfer-line" />
-                <span>Copy to files directory</span>
-              </button>
-            </.menu_item>
-            <.menu_item disabled={not Livebook.Session.file_entry_cacheable?(@session, file_entry)}>
-              <button
-                role="menuitem"
-                phx-click={
-                  JS.push("clear_file_entry_cache",
-                    value: %{name: file_entry.name},
-                    target: @myself
-                  )
-                }
-              >
-                <.remix_icon icon="eraser-line" />
-                <span>Clear cache</span>
-              </button>
-            </.menu_item>
-            <.menu_item>
-              <a role="menuitem" href={~p"/sessions/#{@session.id}/files/download/#{file_entry.name}"}>
-                <.remix_icon icon="download-2-line" />
-                <span>Download</span>
-              </a>
-            </.menu_item>
-            <.menu_item variant={:danger}>
-              <button
-                role="menuitem"
-                phx-click={
-                  JS.push("delete_file_entry", value: %{name: file_entry.name}, target: @myself)
-                }
-              >
-                <.remix_icon icon="delete-bin-line" />
-                <span>Delete</span>
-              </button>
-            </.menu_item>
-          </.menu>
+          <%= if file_entry.name in @transferring_file_entry_names do %>
+            <.spinner class="mr-[3px]" />
+          <% else %>
+            <.menu id={"file-entry-#{idx}-menu"} position={:bottom_right}>
+              <:toggle>
+                <button class="icon-button" aria-label="menu">
+                  <.remix_icon icon="more-2-line" />
+                </button>
+              </:toggle>
+              <.menu_item>
+                <button
+                  :if={file_entry.type != :attachment}
+                  role="menuitem"
+                  phx-click={
+                    JS.push("transfer_file_entry", value: %{name: file_entry.name}, target: @myself)
+                  }
+                >
+                  <.remix_icon icon="file-transfer-line" />
+                  <span>Copy to files directory</span>
+                </button>
+              </.menu_item>
+              <.menu_item disabled={not Livebook.Session.file_entry_cacheable?(@session, file_entry)}>
+                <button
+                  role="menuitem"
+                  phx-click={
+                    JS.push("clear_file_entry_cache",
+                      value: %{name: file_entry.name},
+                      target: @myself
+                    )
+                  }
+                >
+                  <.remix_icon icon="eraser-line" />
+                  <span>Clear cache</span>
+                </button>
+              </.menu_item>
+              <.menu_item>
+                <a
+                  role="menuitem"
+                  href={~p"/sessions/#{@session.id}/files/download/#{file_entry.name}"}
+                >
+                  <.remix_icon icon="download-2-line" />
+                  <span>Download</span>
+                </a>
+              </.menu_item>
+              <.menu_item variant={:danger}>
+                <button
+                  role="menuitem"
+                  phx-click={
+                    JS.push("delete_file_entry", value: %{name: file_entry.name}, target: @myself)
+                  }
+                >
+                  <.remix_icon icon="delete-bin-line" />
+                  <span>Delete</span>
+                </button>
+              </.menu_item>
+            </.menu>
+          <% end %>
         </div>
       </div>
       <div class="flex mt-5">
@@ -215,10 +229,16 @@ defmodule LivebookWeb.SessionLive.FilesListComponent do
 
       Task.Supervisor.async_nolink(Livebook.TaskSupervisor, fn ->
         file_entry_result = Livebook.Session.to_attachment_file_entry(session, file_entry)
-        send_update(pid, __MODULE__, id: id, transfer_file_entry_result: file_entry_result)
+
+        send_update(pid, __MODULE__,
+          id: id,
+          transfer_file_entry_result: {name, file_entry_result}
+        )
       end)
     end
 
+    socket = update(socket, :transferring_file_entry_names, &MapSet.put(&1, name))
+
     {:noreply, socket}
   end