From ebab482b7ef4f0d210f71bfd74f11474685981ab Mon Sep 17 00:00:00 2001 From: ByeongUk Choi Date: Sun, 25 Jun 2023 16:44:36 +0900 Subject: [PATCH] Improve error message when deploying notebooks without settings (#2008) --- lib/livebook/apps.ex | 4 +++- test/livebook/apps_test.exs | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/livebook/apps.ex b/lib/livebook/apps.ex index b5e3eebe3..0161d61d4 100644 --- a/lib/livebook/apps.ex +++ b/lib/livebook/apps.ex @@ -188,7 +188,9 @@ defmodule Livebook.Apps do warnings = Enum.map(warnings, &("Import: " <> &1)) deploy(notebook, warnings: warnings) else - Logger.warning("Skipping app deployment at #{path} due to invalid settings") + Logger.warning( + "Skipping app deployment at #{path}. The deployment settings are missing or invalid. Please configure them under the notebook deploy panel." + ) end end diff --git a/test/livebook/apps_test.exs b/test/livebook/apps_test.exs index bcc196182..e44cc963d 100644 --- a/test/livebook/apps_test.exs +++ b/test/livebook/apps_test.exs @@ -49,7 +49,8 @@ defmodule Livebook.AppsTest do assert capture_log(fn -> Livebook.Apps.deploy_apps_in_dir(tmp_dir) - end) =~ "Skipping app deployment at #{app_path} due to invalid settings" + end) =~ + "Skipping app deployment at #{app_path}. The deployment settings are missing or invalid. Please configure them under the notebook deploy panel." end @tag :tmp_dir