livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-09-07 13:34:55 +08:00
Code Issues Projects Releases Packages Wiki Activity

Fix bug with disabled authorization

Browse source
This commit is contained in:
Alexandre de Souza 2025-05-08 17:36:49 -03:00
parent 2928fab261
commit ef9cd47978
No known key found for this signature in database
GPG key ID: E39228FFBA346545
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/livebook/hubs/team_client.ex
View file

@ -316,7 +316,9 @@ defmodule Livebook.Hubs.TeamClient do
if id = state.deployment_group_id do
case fetch_deployment_group(id, state) do
{:ok, deployment_group} ->
{:reply, authorized_group?(deployment_group.authorization_groups, groups), state}
{:reply,
not deployment_group.groups_auth or
authorized_group?(deployment_group.authorization_groups, groups), state}
_ ->
{:reply, false, state}
@ -331,8 +333,9 @@ defmodule Livebook.Hubs.TeamClient do
with {:ok, deployment_group} <- fetch_deployment_group(id, state),
{:ok, app_deployment} <- fetch_app_deployment_from_slug(slug, state) do
app_access? =
authorized_group?(deployment_group.authorization_groups, groups) or
authorized_group?(app_deployment.authorization_groups, groups)
not deployment_group.groups_auth or
(authorized_group?(deployment_group.authorization_groups, groups) or
authorized_group?(app_deployment.authorization_groups, groups))
{:reply, app_access?, state}
else
@ -700,7 +703,6 @@ defmodule Livebook.Hubs.TeamClient do
defp handle_event(:deployment_group_created, %Teams.DeploymentGroup{} = deployment_group, state) do
Teams.Broadcasts.deployment_group_created(deployment_group)
put_deployment_group(state, deployment_group)
end

2
lib/livebook/zta/livebook_teams.ex
View file

@ -177,7 +177,7 @@ defmodule Livebook.ZTA.LivebookTeams do
} = payload
restricted_apps_groups =
if Livebook.Hubs.TeamClient.authorization_groups_enabled?(hub_id) and
if not Livebook.Hubs.TeamClient.authorization_groups_enabled?(hub_id) or
Livebook.Hubs.TeamClient.user_full_access?(hub_id, groups) do
nil
else