livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2024-09-20 10:05:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Deprecate warmup_apps.sh in favour of warmup_apps (#2305)

Browse source
This commit is contained in:
Jonatan Kłosko 2023-10-25 12:17:59 +02:00 committed by GitHub
parent 52ac23b4f0
commit f2c5d101c3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
README.md
View file

@ -190,7 +190,7 @@ The following environment variables can be used to configure Livebook on boot:
* `LIVEBOOK_APPS_PATH_WARMUP` - sets the warmup mode for apps deployed from
`LIVEBOOK_APPS_PATH`. Must be either "auto" (apps are warmed up on Livebook
startup, right before app deployment) or "manual" (apps are warmed up when
building the Docker image; to do so add "RUN /app/bin/warmup_apps.sh" to
building the Docker image; to do so add "RUN /app/bin/warmup_apps" to
your image). Defaults to "auto".
* `LIVEBOOK_BASE_URL_PATH` - sets the base url path the web application is

2
lib/livebook/hubs/dockerfile.ex
View file

@ -112,7 +112,7 @@ defmodule Livebook.Hubs.Dockerfile do
apps_warmup = """
# Cache apps setup at build time
RUN /app/bin/warmup_apps.sh
RUN /app/bin/warmup_apps
"""
random_secret_key_base = Livebook.Utils.random_secret_key_base()

4
rel/server/overlays/bin/warmup_apps Executable file
View file

@ -0,0 +1,4 @@
#!/bin/sh
cd -P -- "$(dirname -- "$0")"
exec ./livebook eval Livebook.Release.warmup_apps

2
rel/server/overlays/bin/warmup_apps.sh
View file

@ -1,4 +1,6 @@
#!/bin/sh
echo "Using warmup_apps.sh is deprecated. Please use warmup_apps instead."
cd -P -- "$(dirname -- "$0")"
exec ./livebook eval Livebook.Release.warmup_apps

4
test/livebook/hubs/dockerfile_test.exs
View file

@ -31,7 +31,7 @@ defmodule Livebook.Hubs.DockerfileTest do
COPY notebook.livemd /apps/
# Cache apps setup at build time
RUN /app/bin/warmup_apps.sh
RUN /app/bin/warmup_apps
"""
# With secrets
@ -113,7 +113,7 @@ defmodule Livebook.Hubs.DockerfileTest do
COPY notebook.livemd /apps/
# Cache apps setup at build time
RUN /app/bin/warmup_apps.sh
RUN /app/bin/warmup_apps
"""
# With secrets