From f7728c685930b5da22aaf64b540a2edf7347bd86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hugo=20Bara=C3=BAna?= Date: Fri, 19 Apr 2024 10:45:32 -0300 Subject: [PATCH] Change copy about the relationship of a notebook and secrets (#2575) --- lib/livebook_web/live/hub/edit/personal_component.ex | 5 ++--- lib/livebook_web/live/hub/edit/team_component.ex | 6 ++---- .../live/session_live/secrets_component.ex | 4 ++-- .../live/session_live/secrets_list_component.ex | 10 +++++----- 4 files changed, 11 insertions(+), 14 deletions(-) diff --git a/lib/livebook_web/live/hub/edit/personal_component.ex b/lib/livebook_web/live/hub/edit/personal_component.ex index 0a672b2a9..08313669e 100644 --- a/lib/livebook_web/live/hub/edit/personal_component.ex +++ b/lib/livebook_web/live/hub/edit/personal_component.ex @@ -89,9 +89,8 @@ defmodule LivebookWeb.Hub.Edit.PersonalComponent do

- Secrets are a safe way to share credentials and tokens with notebooks. - They are often used by Smart cells and can be read as - environment variables using the LB_ prefix. + Secrets are a safe way to allow notebooks to access + credentials and tokens.

<.live_component diff --git a/lib/livebook_web/live/hub/edit/team_component.ex b/lib/livebook_web/live/hub/edit/team_component.ex index 482a6c456..5eb914006 100644 --- a/lib/livebook_web/live/hub/edit/team_component.ex +++ b/lib/livebook_web/live/hub/edit/team_component.ex @@ -162,10 +162,8 @@ defmodule LivebookWeb.Hub.Edit.TeamComponent do

- Secrets are a safe way to share credentials and tokens with notebooks - across your whole team. - They are often used by Smart cells and can be read as - environment variables using the LB_ prefix. + Secrets are a safe way to allow notebooks to access + credentials and tokens.

<.live_component diff --git a/lib/livebook_web/live/session_live/secrets_component.ex b/lib/livebook_web/live/session_live/secrets_component.ex index 0eaef764f..c1c83651e 100644 --- a/lib/livebook_web/live/session_live/secrets_component.ex +++ b/lib/livebook_web/live/session_live/secrets_component.ex @@ -187,7 +187,7 @@ defmodule LivebookWeb.SessionLive.SecretsComponent do
-
+
<.remix_icon icon="error-warning-fill" class="align-middle text-2xl flex text-gray-100 rounded-lg py-2" @@ -195,7 +195,7 @@ defmodule LivebookWeb.SessionLive.SecretsComponent do There is a secret named <%= @secret.name %> - in <%= hub_label(@hub) %>. Allow this session to access it? + in the <%= hub_label(@hub) %> workspace. Allow this notebook to access it?
<.button diff --git a/lib/livebook_web/live/session_live/secrets_list_component.ex b/lib/livebook_web/live/session_live/secrets_list_component.ex index 8d04a2207..65ad17a83 100644 --- a/lib/livebook_web/live/session_live/secrets_list_component.ex +++ b/lib/livebook_web/live/session_live/secrets_list_component.ex @@ -47,7 +47,7 @@ defmodule LivebookWeb.SessionLive.SecretsListComponent do <%= if @hub_secrets == [] do %> No secrets stored in this hub so far <% else %> - Toggle to share with this session + Toggle to allow access to a secret <% end %>
@@ -195,10 +195,10 @@ defmodule LivebookWeb.SessionLive.SecretsListComponent do class="tooltip bottom-left" data-tooltip={ ~S''' - Secrets are a safe way to share credentials - and tokens with notebooks. They are often - shared with Smart cells and can be read as - environment variables using the LB_ prefix. + Secrets are a safe way to allow notebooks + to access credentials and tokens. + Your notebook can read them as environment + variables using the LB_ prefix. ''' } >