From fbb387e882ca9b44a92847a5891bf3a7e29713b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonatan=20K=C5=82osko?= Date: Mon, 19 Aug 2024 16:14:52 +0200 Subject: [PATCH] Do not set XLA_TARGET when using Livebook CUDA-based images (#2755) --- lib/livebook/config.ex | 6 +----- test/livebook/hubs/dockerfile_test.exs | 5 +---- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/livebook/config.ex b/lib/livebook/config.ex index 9ccfac6be..616fa99e3 100644 --- a/lib/livebook/config.ex +++ b/lib/livebook/config.ex @@ -65,11 +65,7 @@ defmodule Livebook.Config do [ %{tag: version, name: "Livebook", env: []}, - %{ - tag: "#{version}-cuda12", - name: "Livebook + CUDA 12", - env: [{"XLA_TARGET", "cuda120"}] - } + %{tag: "#{version}-cuda12", name: "Livebook + CUDA 12", env: []} ] end diff --git a/test/livebook/hubs/dockerfile_test.exs b/test/livebook/hubs/dockerfile_test.exs index 18bd82d51..2ae1c0d10 100644 --- a/test/livebook/hubs/dockerfile_test.exs +++ b/test/livebook/hubs/dockerfile_test.exs @@ -174,8 +174,6 @@ defmodule Livebook.Hubs.DockerfileTest do assert dockerfile =~ """ FROM ghcr.io/livebook-dev/livebook:#{@version}-cuda12 - - ENV XLA_TARGET "cuda120" """ end @@ -251,10 +249,9 @@ defmodule Livebook.Hubs.DockerfileTest do hub = team_hub() agent_key = Livebook.Factory.build(:agent_key) - %{image: image, env: env} = Dockerfile.online_docker_info(config, hub, agent_key) + %{image: image, env: _env} = Dockerfile.online_docker_info(config, hub, agent_key) assert image == "ghcr.io/livebook-dev/livebook:#{@version}-cuda12" - assert {"XLA_TARGET", "cuda120"} in env end test "deploying with auto cluster setup" do