mirror of
https://github.com/livebook-dev/livebook.git
synced 2025-10-17 00:46:14 +08:00
Disables deployment group mode editing (#2476)
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
This commit is contained in:
parent
ce53cdeb3c
commit
fe5598dbb5
3 changed files with 10 additions and 4 deletions
|
@ -58,6 +58,7 @@ defmodule LivebookWeb.Hub.Teams.DeploymentGroupFormComponent do
|
|||
phx-debounce
|
||||
/>
|
||||
<.select_field
|
||||
:if={@mode == :new}
|
||||
label="Mode"
|
||||
help={
|
||||
~S'''
|
||||
|
@ -70,6 +71,7 @@ defmodule LivebookWeb.Hub.Teams.DeploymentGroupFormComponent do
|
|||
{"Online", :online}
|
||||
]}
|
||||
/>
|
||||
<.hidden_field :if={@mode != :new} field={f[:mode]} value={@deployment_group.mode} />
|
||||
<LivebookWeb.AppComponents.deployment_group_form_content hub={@hub} form={f} />
|
||||
<div class="flex space-x-2">
|
||||
<.button type="submit" disabled={not @changeset.valid?}>
|
||||
|
@ -142,8 +144,8 @@ defmodule LivebookWeb.Hub.Teams.DeploymentGroupFormComponent do
|
|||
defp subtitle(%DeploymentGroup{name: nil}, hub_name),
|
||||
do: "Add a new deployment group to #{hub_name}"
|
||||
|
||||
defp subtitle(%DeploymentGroup{name: deployment_group}, _),
|
||||
do: "Manage the #{deployment_group} deployment group"
|
||||
defp subtitle(%DeploymentGroup{name: deployment_group, mode: mode}, _),
|
||||
do: "Manage the #{deployment_group} (#{mode}) deployment group"
|
||||
|
||||
defp button_attrs(%DeploymentGroup{name: nil}), do: %{icon: "add-line", label: "Add"}
|
||||
defp button_attrs(_), do: %{icon: "save-line", label: "Save"}
|
||||
|
|
|
@ -92,7 +92,9 @@ defmodule LivebookWeb.Integration.Hub.DeploymentGroupLiveTest do
|
|||
live(conn, ~p"/hub/#{hub.id}/deployment-groups/edit/#{deployment_group.id}")
|
||||
|
||||
assert html =~ "Edit deployment group"
|
||||
assert html =~ "Manage the #{deployment_group.name} deployment group"
|
||||
|
||||
assert html =~
|
||||
"Manage the #{deployment_group.name} (#{deployment_group.mode}) deployment group"
|
||||
|
||||
view
|
||||
|> element("#deployment-groups-form")
|
||||
|
|
|
@ -387,7 +387,9 @@ defmodule LivebookWeb.Integration.Hub.EditLiveTest do
|
|||
live(conn, ~p"/hub/#{hub.id}/deployment-groups/edit/#{deployment_group.id}")
|
||||
|
||||
assert html =~ "Edit deployment group"
|
||||
assert html =~ "Manage the #{deployment_group.name} deployment group"
|
||||
|
||||
assert html =~
|
||||
"Manage the #{deployment_group.name} (#{deployment_group.mode}) deployment group"
|
||||
|
||||
view
|
||||
|> element("#deployment-groups-form")
|
||||
|
|
Loading…
Add table
Reference in a new issue