livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-10-18 01:16:29 +08:00
Code Issues Projects Releases Packages Wiki Activity

Disables deployment group mode editing (#2476)

Browse source 
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
This commit is contained in:
Cristine Guadelupe 2024-02-09 09:41:32 +07:00 • committed by GitHub
parent ce53cdeb3c
commit fe5598dbb5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/livebook_web/live/hub/teams/deployment_group_form_component.ex
View file

@ -58,6 +58,7 @@ defmodule LivebookWeb.Hub.Teams.DeploymentGroupFormComponent do
phx-debounce phx-debounce
/> />
<.select_field <.select_field
:if={@mode == :new}
label="Mode" label="Mode"
help={ help={
~S''' ~S'''
@ -70,6 +71,7 @@ defmodule LivebookWeb.Hub.Teams.DeploymentGroupFormComponent do
{"Online", :online} {"Online", :online}
]} ]}
/> />
<.hidden_field :if={@mode != :new} field={f[:mode]} value={@deployment_group.mode} />
<LivebookWeb.AppComponents.deployment_group_form_content hub={@hub} form={f} /> <LivebookWeb.AppComponents.deployment_group_form_content hub={@hub} form={f} />
<div class="flex space-x-2"> <div class="flex space-x-2">
<.button type="submit" disabled={not @changeset.valid?}> <.button type="submit" disabled={not @changeset.valid?}>
@ -142,8 +144,8 @@ defmodule LivebookWeb.Hub.Teams.DeploymentGroupFormComponent do
defp subtitle(%DeploymentGroup{name: nil}, hub_name), defp subtitle(%DeploymentGroup{name: nil}, hub_name),
do: "Add a new deployment group to #{hub_name}" do: "Add a new deployment group to #{hub_name}"
defp subtitle(%DeploymentGroup{name: deployment_group}, _), defp subtitle(%DeploymentGroup{name: deployment_group, mode: mode}, _),
do: "Manage the #{deployment_group} deployment group" do: "Manage the #{deployment_group} (#{mode}) deployment group"
defp button_attrs(%DeploymentGroup{name: nil}), do: %{icon: "add-line", label: "Add"} defp button_attrs(%DeploymentGroup{name: nil}), do: %{icon: "add-line", label: "Add"}
defp button_attrs(_), do: %{icon: "save-line", label: "Save"} defp button_attrs(_), do: %{icon: "save-line", label: "Save"}

4
test/livebook_teams/web/hub/deployment_group_live_test.exs
View file

@ -92,7 +92,9 @@ defmodule LivebookWeb.Integration.Hub.DeploymentGroupLiveTest do
live(conn, ~p"/hub/#{hub.id}/deployment-groups/edit/#{deployment_group.id}") live(conn, ~p"/hub/#{hub.id}/deployment-groups/edit/#{deployment_group.id}")
assert html =~ "Edit deployment group" assert html =~ "Edit deployment group"
assert html =~ "Manage the #{deployment_group.name} deployment group"
assert html =~
"Manage the #{deployment_group.name} (#{deployment_group.mode}) deployment group"
view view
|> element("#deployment-groups-form") |> element("#deployment-groups-form")

4
test/livebook_teams/web/hub/edit_live_test.exs
View file

@ -387,7 +387,9 @@ defmodule LivebookWeb.Integration.Hub.EditLiveTest do
live(conn, ~p"/hub/#{hub.id}/deployment-groups/edit/#{deployment_group.id}") live(conn, ~p"/hub/#{hub.id}/deployment-groups/edit/#{deployment_group.id}")
assert html =~ "Edit deployment group" assert html =~ "Edit deployment group"
assert html =~ "Manage the #{deployment_group.name} deployment group"
assert html =~
"Manage the #{deployment_group.name} (#{deployment_group.mode}) deployment group"
view view
|> element("#deployment-groups-form") |> element("#deployment-groups-form")