livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-11-09 13:44:53 +08:00
Code Issues Projects Releases Packages Wiki Activity

Removing "Evaluate All Below" shortcut functionality (#621)

Browse source
This commit is contained in:
Matheus Cumpian 2021-10-19 18:36:44 -03:00 • committed by GitHub
parent 33f13c03f9
commit fe77823685
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
assets/js/session/index.js
View file

@ -335,8 +335,6 @@ function handleDocumentKeyDown(hook, event) {
queueAllCellsEvaluation(hook); queueAllCellsEvaluation(hook);
} else if (keyBuffer.tryMatch(["e", "s"])) { } else if (keyBuffer.tryMatch(["e", "s"])) {
queueFocusedSectionEvaluation(hook); queueFocusedSectionEvaluation(hook);
} else if (keyBuffer.tryMatch(["e", "j"])) {
queueChildCellsEvaluation(hook);
} else if (keyBuffer.tryMatch(["s", "s"])) { } else if (keyBuffer.tryMatch(["s", "s"])) {
toggleSectionsList(hook); toggleSectionsList(hook);
} else if (keyBuffer.tryMatch(["s", "u"])) { } else if (keyBuffer.tryMatch(["s", "u"])) {
@ -640,14 +638,6 @@ function queueFocusedSectionEvaluation(hook) {
} }
} }
function queueChildCellsEvaluation(hook) {
if (hook.state.focusedCellId) {
hook.pushEvent("queue_child_cells_evaluation", {
cell_id: hook.state.focusedCellId,
});
}
}
function cancelFocusedCellEvaluation(hook) { function cancelFocusedCellEvaluation(hook) {
if (hook.state.focusedCellId) { if (hook.state.focusedCellId) {
hook.pushEvent("cancel_cell_evaluation", { hook.pushEvent("cancel_cell_evaluation", {

12
lib/livebook_web/live/session_live.ex
View file

@ -579,18 +579,6 @@ defmodule LivebookWeb.SessionLive do
{:noreply, socket} {:noreply, socket}
end end
def handle_event("queue_child_cells_evaluation", %{"cell_id" => cell_id}, socket) do
with {:ok, cell, _section} <-
Notebook.fetch_cell_and_section(socket.private.data.notebook, cell_id) do
for {cell, _} <- Notebook.child_cells_with_section(socket.private.data.notebook, cell.id),
is_struct(cell, Cell.Elixir) do
Session.queue_cell_evaluation(socket.assigns.session.pid, cell.id)
end
end
{:noreply, socket}
end
def handle_event("queue_bound_cells_evaluation", %{"cell_id" => cell_id}, socket) do def handle_event("queue_bound_cells_evaluation", %{"cell_id" => cell_id}, socket) do
data = socket.private.data data = socket.private.data

1
lib/livebook_web/live/session_live/shortcuts_component.ex
View file

@ -96,7 +96,6 @@ defmodule LivebookWeb.SessionLive.ShortcutsComponent do
%{seq: ["e", "e"], desc: "Evaluate cell"}, %{seq: ["e", "e"], desc: "Evaluate cell"},
%{seq: ["e", "s"], desc: "Evaluate section"}, %{seq: ["e", "s"], desc: "Evaluate section"},
%{seq: ["e", "a"], desc: "Evaluate all stale/new cells", basic: true}, %{seq: ["e", "a"], desc: "Evaluate all stale/new cells", basic: true},
%{seq: ["e", "j"], desc: "Evaluate cells below"},
%{seq: ["e", "x"], desc: "Cancel cell evaluation"}, %{seq: ["e", "x"], desc: "Cancel cell evaluation"},
%{seq: ["s", "s"], desc: "Toggle sections panel"}, %{seq: ["s", "s"], desc: "Toggle sections panel"},
%{seq: ["s", "u"], desc: "Toggle users panel"}, %{seq: ["s", "u"], desc: "Toggle users panel"},