From feb0ac214e45da5519f4c4df5395e720b72b80ed Mon Sep 17 00:00:00 2001 From: Kevin Date: Wed, 8 Dec 2021 13:17:50 +0100 Subject: [PATCH] Fix error on back after closing session (#769) * Fix error on back after closing session Clicking the browsers back button after closing a session resulted in an error since it was trying to close an already closed notebook * Overwrite back history on section delete --- lib/livebook_web/live/home_live/close_session_component.ex | 2 +- lib/livebook_web/live/session_live/delete_section_component.ex | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/livebook_web/live/home_live/close_session_component.ex b/lib/livebook_web/live/home_live/close_session_component.ex index 2ceff6486..d93bf3ccd 100644 --- a/lib/livebook_web/live/home_live/close_session_component.ex +++ b/lib/livebook_web/live/home_live/close_session_component.ex @@ -30,6 +30,6 @@ defmodule LivebookWeb.HomeLive.CloseSessionComponent do @impl true def handle_event("close", %{}, socket) do Livebook.Session.close(socket.assigns.session.pid) - {:noreply, push_patch(socket, to: socket.assigns.return_to)} + {:noreply, push_patch(socket, to: socket.assigns.return_to, replace: true)} end end diff --git a/lib/livebook_web/live/session_live/delete_section_component.ex b/lib/livebook_web/live/session_live/delete_section_component.ex index aea697d37..8bbb78385 100644 --- a/lib/livebook_web/live/session_live/delete_section_component.ex +++ b/lib/livebook_web/live/session_live/delete_section_component.ex @@ -44,6 +44,6 @@ defmodule LivebookWeb.SessionLive.DeleteSectionComponent do delete_cells? ) - {:noreply, push_patch(socket, to: socket.assigns.return_to)} + {:noreply, push_patch(socket, to: socket.assigns.return_to, replace: true)} end end