livebook/lib/livebook_web/live/home_live/edit_sessions_component.ex
José Valim d2344a5c3b
Improve memory tracking and address race conditions (#957)
1. Allow multiple sessions to close or disconnect at once,
     and then request the system resources to be updated

  2. Make sure that closing a session happens synchronously,
     otherwise a race condition could still list the closed
     session in a dashboard

  3. Ensure close and disconnect can happen more than once
     (for example if two users click the same button at the
     same time)
2022-01-30 12:47:50 +01:00

78 lines
2.5 KiB
Elixir

defmodule LivebookWeb.HomeLive.EditSessionsComponent do
use LivebookWeb, :live_component
import LivebookWeb.HomeLive.SessionListComponent, only: [toggle_edit: 1]
@impl true
def render(assigns) do
~H"""
<div class="p-6 pb-4 flex flex-col space-y-8">
<h3 class="text-2xl font-semibold text-gray-800">
<%= title(@action) %>
</h3>
<.message action={@action} selected_sessions={@selected_sessions} sessions={@sessions}/>
<div class="mt-8 flex justify-end space-x-2">
<button class="button-base button-red" role="button"
phx-click={toggle_edit(:off) |> JS.push(@action, target: @myself)}>
<.remix_icon icon="close-circle-line" class="align-middle mr-1" />
<%= button_label(@action) %>
</button>
<%= live_patch "Cancel", to: @return_to, class: "button-base button-outlined-gray" %>
</div>
</div>
"""
end
defp message(%{action: "close_all"} = assigns) do
~H"""
<p class="text-gray-700">
Are you sure you want to close <%= pluralize(length(@selected_sessions), "session", "sessions") %>?
<%= if not_persisted_count(@selected_sessions) > 0 do %>
<br/>
<span class="font-medium">Important:</span>
<%= pluralize(
not_persisted_count(@selected_sessions),
"notebook is not persisted and its content may be lost.",
"notebooks are not persisted and their content may be lost."
) %>
<% end %>
</p>
"""
end
defp message(%{action: "disconnect"} = assigns) do
~H"""
<p class="text-gray-700">
Are you sure you want to disconnect <%= pluralize(length(@selected_sessions), "session", "sessions") %>?
</p>
"""
end
@impl true
def handle_event("close_all", %{}, socket) do
socket.assigns.selected_sessions
|> Enum.map(& &1.pid)
|> Livebook.Session.close()
{:noreply, push_patch(socket, to: socket.assigns.return_to, replace: true)}
end
def handle_event("disconnect", %{}, socket) do
socket.assigns.selected_sessions
|> Enum.reject(&(&1.memory_usage.runtime == nil))
|> Enum.map(& &1.pid)
|> Livebook.Session.disconnect_runtime()
{:noreply, push_patch(socket, to: socket.assigns.return_to, replace: true)}
end
defp button_label("close_all"), do: "Close sessions"
defp button_label("disconnect"), do: "Disconnect runtime"
defp title("close_all"), do: "Close sessions"
defp title("disconnect"), do: "Disconnect runtime"
defp not_persisted_count(selected_sessions) do
Enum.count(selected_sessions, &(!&1.file))
end
end