mirror of
https://github.com/livebook-dev/livebook.git
synced 2024-11-13 19:31:31 +08:00
c6d7c81ee9
* adding a new info flash on imported notebooks * changing the imported notebook error flashes to warning level * Update lib/livebook_web/live/session_helpers.ex Co-authored-by: José Valim <jose.valim@gmail.com> * adding unit tests for the flash messages and fixing put_import_flash/1 call location * changing name of put_import_flash_messages/2 to put_import_warnings * Update lib/livebook_web/live/home_live.ex * formating code Co-authored-by: José Valim <jose.valim@gmail.com> Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
54 lines
1.6 KiB
Elixir
54 lines
1.6 KiB
Elixir
defmodule LivebookWeb.SessionHelpers do
|
|
import Phoenix.LiveView
|
|
alias LivebookWeb.Router.Helpers, as: Routes
|
|
|
|
@doc """
|
|
Creates a new session, redirects on success,
|
|
puts an error flash message on failure.
|
|
|
|
Accepts the same options as `Livebook.Sessions.create_session/1`.
|
|
"""
|
|
@spec create_session(Phoenix.LiveView.Socket.t(), keyword()) :: Phoenix.LiveView.Socket.t()
|
|
def create_session(socket, opts \\ []) do
|
|
# Revert persistence options to default values if there is
|
|
# no file attached to the new session
|
|
opts =
|
|
if opts[:notebook] != nil and opts[:file] == nil do
|
|
Keyword.update!(opts, :notebook, &Livebook.Notebook.reset_persistence_options/1)
|
|
else
|
|
opts
|
|
end
|
|
|
|
case Livebook.Sessions.create_session(opts) do
|
|
{:ok, session} ->
|
|
push_redirect(socket, to: Routes.session_path(socket, :page, session.id))
|
|
|
|
{:error, reason} ->
|
|
put_flash(socket, :error, "Failed to create session: #{reason}")
|
|
end
|
|
end
|
|
|
|
@doc """
|
|
Formats the given list of notebook import messages and puts
|
|
into the warning flash.
|
|
"""
|
|
@spec put_import_warnings(Phoenix.LiveView.Socket.t(), list(String.t())) ::
|
|
Phoenix.LiveView.Socket.t()
|
|
def put_import_warnings(socket, messages)
|
|
|
|
def put_import_warnings(socket, []), do: socket
|
|
|
|
def put_import_warnings(socket, messages) do
|
|
list =
|
|
messages
|
|
|> Enum.map(fn message -> ["- ", message] end)
|
|
|> Enum.intersperse("\n")
|
|
|
|
flash =
|
|
IO.iodata_to_binary([
|
|
"We found problems while importing the file and tried to autofix them:\n" | list
|
|
])
|
|
|
|
put_flash(socket, :warning, flash)
|
|
end
|
|
end
|