From 1233d266a1736ec73d0cd3b66f69aac39e147108 Mon Sep 17 00:00:00 2001 From: Ferotiq <64989416+Ferotiq@users.noreply.github.com> Date: Sun, 20 Feb 2022 15:29:39 -0600 Subject: [PATCH] Fix (#2550) * Update package.json * Update CONTRIBUTING.md * Update install.cmd * Update pr-check.yml --- .github/workflows/pr-check.yml | 2 +- CONTRIBUTING.md | 2 +- bin/install.cmd | 6 +++--- package.json | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 9e8095505..595bcd1fb 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -59,7 +59,7 @@ jobs: - name: Install dependencies if: steps.filter.outputs.changes != '[]' - run: npm run install + run: npm run install:all # - name: Run webpack # run: npm run build:live diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d07f9c666..85acefe54 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -93,7 +93,7 @@ Follow these steps if you want to work on anything involving the database/accoun Once you have completed the above steps, you are ready to build and run Monkeytype. -1. Run `npm run install` in the project root to install all dependencies. +1. Run `npm run install:all` in the project root to install all dependencies. - If you are on Windows, use `npm run install:windows`. - If none of this works, you will have to run `npm install` in root, frontend, and backend directories. 2. Run `npm run start:dev` (`npm run start:dev:fe` if you skipped the mongo section) to start a local dev server on [port 5000](http://localhost:5000). It will watch for changes and rebuild when you edit files in `src/` or `public/` directories. Note that rebuilding doesn't happen instantaneously so be patient for changes to appear. Use Ctrl+C to kill it. diff --git a/bin/install.cmd b/bin/install.cmd index 24131bf97..4a3a2d27e 100644 --- a/bin/install.cmd +++ b/bin/install.cmd @@ -1,7 +1,7 @@ -npm ci +call npm ci cd .\frontend -npm ci +call npm ci cd ..\backend -npm ci +call npm ci cd ..\ PAUSE diff --git a/package.json b/package.json index 9879764a9..f33e7d0ce 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "start:dev:be": "cd backend && npm run start:dev", "start:dev:fe": "cd frontend && npm run start:dev", "deploy:live": "cd frontend && npm run deploy:live", - "install": "sh ./bin/install.sh", + "install:all": "sh ./bin/install.sh", "install:windows": ".\\bin\\install.cmd", "lint": "run-script-os", "lint:windows": ".\\node_modules\\.bin\\eslint \"./backend/**/*.{ts,js}\" \"./frontend/src/scripts/**/*.{ts,js}\"",