moved click handler to script files

frontend/src/ts/popups/cookie-popup.ts

@@ -1,5 +1,6 @@
 import { activateAnalytics } from "../controllers/analytics-controller";
 import { focusWords } from "../test/test-ui";
+import * as Notifications from "../elements/notifications";
 
 let visible = false;
 
@@ -109,3 +110,18 @@ $(document).on("keypress", (e) => {
     e.preventDefault();
   }
 });
+
+$("#cookiePopup .cookie.ads .text-button").on("click", () => {
+  try {
+    //@ts-ignore
+    window.__tcfapi("displayConsentUi", 2, function () {
+      //
+    });
+  } catch (e) {
+    console.error("Failed to open ad consent UI");
+    Notifications.add(
+      "Failed to open Ad consent popup. Do you have an ad or cookie popup blocker enabled?",
+      -1
+    );
+  }
+});

frontend/static/html/popups.html

@@ -71,10 +71,7 @@
             Our advertising partner may use cookies to deliver ads that are more
             relevant to you.
           </div>
-          <a
-            class="text-button"
-            onclick="window.__tcfapi('displayConsentUi', 2, function() {} );"
-          >
+          <a class="text-button">
             Click to change your preferences on ad related cookies
           </a>
         </label>